-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to Parquet 1.14.1 #10209
base: main
Are you sure you want to change the base?
Bump to Parquet 1.14.1 #10209
Conversation
cbc368e
to
cb9eae0
Compare
157079b
to
ca2100e
Compare
ca2100e
to
4b168b4
Compare
build.gradle
Outdated
} | ||
dependencies { | ||
classpath 'com.github.johnrengelman:shadow:8.1.1' | ||
classpath "io.github.goooler.shadow:shadow-gradle-plugin:8.1.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an issue with the plugin: GradleUp/shadow#911
5c3b0bc
to
8d3ce50
Compare
7fb72a2
to
e0b7277
Compare
The tests are failing, but that's because Jackson ships with JDK21-specific code, and the shadow plugin cannot cope with that. There is a fork of the plugin, but that one requires Gradle 8.3+. Gradle plugins are blocked because revapi is not being maintained and does not work with Gradle |
Yes, I will move forward on the Gradle/revapi PR (a bit busy with a few Avro stuff 😄 ). |
c2764b3
to
457c2a1
Compare
457c2a1
to
565352d
Compare
9650d77
to
74dc596
Compare
Looks like there are erroneously issues with the duplicate classes, but they are JVM specific:
Unfortunally, we cannot upgrade |
@Fokko do you want me to check if I can do a baseline gradle plugin version JDK8 compliant dealing with that duplicated classes ? |
Feel free to dig into it. The current version that we use is from November 2021: https://github.com/palantir/gradle-baseline/releases/tag/4.42.0 :( |
@Fokko ok let me take a look. I think it would be great to include Parquet update in Iceberg 1.6.0 release. |
I'm also good to leave this one out for the 1.6.0 release. I think it is going to be quite a bit of work. |
Yeah I think it's reasonable. Thanks. |
@jbonofre: I don't think we should maintain private forks of these. |
@ajantha-bhat my previous comment was not about doing a private plugin fork, it was more about fixing the plugin. Palantir seems to still maintain the baseline plugin, so I can provide a PR. |
Change LGTM, but FYI, the build is failing. |
@findepi Looks like some false positive from the shadow plugin that's unable to coop with the Java-version specific files. Have to dig deeper into this. |
To assess the impact of the changes.
Blocked by #8485