-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Drop support for Java 8 #10518
Conversation
4096cb9
to
5fd990a
Compare
Thanks @ajantha-bhat for linking the two!
Technically this PR is ready to go (i.e. please review!). |
Please have a separate discussion for dropping JDK 8 support. Mixing things can slowdown the decision making usually. |
@ajantha-bhat it's not really mixed. I intended the thread to focus on adding 21, but folks decided to focus on dropping 8, as this clearly is more important, so this is all the thread is about. I wish we could just change it's title... |
|
( rebased to resolve conflicts with now-merged #10474, no other changes ) |
Rebased to update formatting in flink/v1.19 classes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. I will start the following PRs thanks to that !
Moved to 1.7.0 milestone per |
Thanks for getting this through, @findepi! |
nice. now, who is going to do the "drop hadoop2 profile", so letting iceberg move to filesystem APIs written since 2016? |
@steveloughran do you want to do the honors @steveloughran? |
can give it a go, its time I learned gradle properly. but busy with helping getting 3.4.1 out the door, including those final changes |
Relates to: #10474