Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Drop support for Java 8 #10518

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Core: Drop support for Java 8 #10518

merged 1 commit into from
Aug 2, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Jun 17, 2024

Relates to: #10474

baseline.gradle Outdated Show resolved Hide resolved
@findepi
Copy link
Member Author

findepi commented Jul 16, 2024

This PR can also help in unblocking parquet version bump: #10209 (comment)

Thanks @ajantha-bhat for linking the two!

@findepi: Are you still working on this? I think this one is more important than JDK 21 support.

Technically this PR is ready to go (i.e. please review!).
However, there is no agreement yet as to when this should be merged, see the thread on the mailing list.

@ajantha-bhat
Copy link
Member

However, there is no agreement yet as to when this should be merged, see the thread on the mailing list.

Please have a separate discussion for dropping JDK 8 support. Mixing things can slowdown the decision making usually.
Also mention that it is needed to unblock the parquet bump.

@findepi
Copy link
Member Author

findepi commented Jul 16, 2024

@ajantha-bhat it's not really mixed. I intended the thread to focus on adding 21, but folks decided to focus on dropping 8, as this clearly is more important, so this is all the thread is about. I wish we could just change it's title...

@steveloughran
Copy link
Contributor

  • making java11 your base version is great -but you'll need a followup of 'cut hadoop-2' profile. this is a good thing
  • java 22 is going to break a lost as they will cut Subject.doAs(), which used throughout multi-user services. just be aware that it'll be traumatic.

@findepi
Copy link
Member Author

findepi commented Jul 25, 2024

( rebased to resolve conflicts with now-merged #10474, no other changes )

@findepi
Copy link
Member Author

findepi commented Jul 26, 2024

Rebased to update formatting in flink/v1.19 classes.
I will move the baseline update commit to separate PR though.

Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I will start the following PRs thanks to that !

@findepi findepi modified the milestones: Iceberg 2.0.0, Iceberg 1.7.0 Aug 1, 2024
@findepi
Copy link
Member Author

findepi commented Aug 1, 2024

Moved to 1.7.0 milestone per [VOTE] Drop Java 8 support in Iceberg 1.7.0 mail list thread. Will merge tomorrow.

@findepi findepi changed the title Drop support for Java 8 core: drop support for Java 8 Aug 2, 2024
@findepi findepi changed the title core: drop support for Java 8 Core: Drop support for Java 8 Aug 2, 2024
@findepi findepi merged commit 9a67f0b into apache:main Aug 2, 2024
45 checks passed
@findepi findepi deleted the findepi/8 branch August 2, 2024 07:23
@rdblue
Copy link
Contributor

rdblue commented Aug 2, 2024

Thanks for getting this through, @findepi!

@steveloughran
Copy link
Contributor

nice. now, who is going to do the "drop hadoop2 profile", so letting iceberg move to filesystem APIs written since 2016?

@Fokko
Copy link
Contributor

Fokko commented Aug 13, 2024

@steveloughran do you want to do the honors @steveloughran?

@steveloughran
Copy link
Contributor

can give it a go, its time I learned gradle properly. but busy with helping getting 3.4.1 out the door, including those final changes

@steveloughran
Copy link
Contributor

@Fokko started that PR. #10932 ...looks like hive2 is dead too. This good in that it will significantly reduce test profiles -but it is going to make the PR at lot more complex. I think I may be getting out of my depth build-wise before very long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants