-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Update baseline gradle plugin to 5.58.0 #10788
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft -- currently depends on #10518 |
jbonofre
reviewed
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this PR "conflicts" with the JDK8 drop one right ?
i think it depends on the other. we can update only after we drop 8. |
@findepi time to revisit this? :) |
Yes! let me rebase |
findepi
force-pushed
the
findepi/baseline
branch
from
August 2, 2024 11:55
ffdd407
to
9d112d1
Compare
nastra
reviewed
Aug 2, 2024
nastra
changed the title
Update baseline gradle plugin to 5.58.0
Build: Update baseline gradle plugin to 5.58.0
Aug 2, 2024
This was referenced Aug 2, 2024
Among other things, this pulls newest version of error-prone which adds new useful checks.
findepi
force-pushed
the
findepi/baseline
branch
from
August 2, 2024 12:46
9d112d1
to
9928b72
Compare
nastra
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among other things, this pulls newest version of error-prone which adds
new useful checks.