Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Update baseline gradle plugin to 5.58.0 #10788

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Jul 26, 2024

Among other things, this pulls newest version of error-prone which adds
new useful checks.

@findepi findepi marked this pull request as draft July 26, 2024 11:52
@findepi
Copy link
Member Author

findepi commented Jul 26, 2024

Draft -- currently depends on #10518

Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this PR "conflicts" with the JDK8 drop one right ?

@findepi
Copy link
Member Author

findepi commented Jul 26, 2024

i think it depends on the other. we can update only after we drop 8.

@Fokko
Copy link
Contributor

Fokko commented Aug 2, 2024

@findepi time to revisit this? :)

@findepi
Copy link
Member Author

findepi commented Aug 2, 2024

Yes! let me rebase

@findepi findepi requested a review from Fokko August 2, 2024 11:55
@findepi findepi marked this pull request as ready for review August 2, 2024 11:55
@findepi findepi requested a review from nastra August 2, 2024 11:59
baseline.gradle Outdated Show resolved Hide resolved
@nastra nastra changed the title Update baseline gradle plugin to 5.58.0 Build: Update baseline gradle plugin to 5.58.0 Aug 2, 2024
Among other things, this pulls newest version of error-prone which adds
new useful checks.
@nastra nastra merged commit 674214c into apache:main Aug 2, 2024
45 checks passed
@findepi findepi deleted the findepi/baseline branch August 2, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants