[VL] support array_join #2705
[VL] support array_join #2705
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
majian4work
force-pushed
the
array_join
branch
from
cec2082 to
fe2cf2e
Compare
|
Run Gluten Clickhouse CI |
|
@PHILO-HE Could you review this PR？ |
majian4work
force-pushed
the
array_join
branch
from
fe2cf2e to
d90d012
Compare
|
Run Gluten Clickhouse CI |
| @@ -658,6 +658,14 @@ object ExpressionConverter extends SQLConfHelper with Logging { | |||
| substraitExprName.get, | |||
| replaceWithExpressionTransformer(arrayMin.child, attributeSeq), | |||
| arrayMin) | |||
| case arrayJoin: ArrayJoin => | |||
There was a problem hiding this comment.
This should not be necessary, as it will be handled by normalFunctionExpressionTransform
There was a problem hiding this comment.
@Ma-Jian1, please have a further check. Thanks!
There was a problem hiding this comment.
Ok, I'll double check it.
There was a problem hiding this comment.
It's covered by normalFunctionExpressionTransform, revert it.
| @@ -658,6 +658,14 @@ object ExpressionConverter extends SQLConfHelper with Logging { | |||
| substraitExprName.get, | |||
| replaceWithExpressionTransformer(arrayMin.child, attributeSeq), | |||
| arrayMin) | |||
| case arrayJoin: ArrayJoin => | |||
There was a problem hiding this comment.
@Ma-Jian1, please have a further check. Thanks!
| @@ -95,6 +95,7 @@ object CHExpressionUtil { | |||
| ) | |||
|
|
|||
| final val CH_BLACKLIST_SCALAR_FUNCTION: Map[String, FunctionValidator] = Map( | |||
| ARRAY_JOIN -> DefaultValidator(), | |||
majian4work
force-pushed
the
array_join
branch
from
d90d012 to
b05b42f
Compare
|
Run Gluten Clickhouse CI |
majian4work
force-pushed
the
array_join
branch
from
b05b42f to
c28d278
Compare
|
Run Gluten Clickhouse CI |
majian4work
force-pushed
the
array_join
branch
from
c28d278 to
43b5ed4
Compare
|
Run Gluten Clickhouse CI |
majian4work
force-pushed
the
array_join
branch
from
43b5ed4 to
1d40a0f
Compare
|
Run Gluten Clickhouse CI |
majian4work
force-pushed
the
array_join
branch
from
1d40a0f to
3643dbb
Compare
|
Run Gluten Clickhouse CI |
Summary: Gluten removed the registration of Presto sql functions. This PR registers Presto array_join function in Spark for reuse. apache/incubator-gluten#2705 Pull Request resolved: #11948 Reviewed By: bikramSingh91 Differential Revision: D67867310 Pulled By: kevinwilfong fbshipit-source-id: 14b18faa7b46802741b58de4ca5e03d5979137d4
Summary: Gluten removed the registration of Presto sql functions. This PR registers Presto array_join function in Spark for reuse. apache/incubator-gluten#2705 Pull Request resolved: facebookincubator#11948 Reviewed By: bikramSingh91 Differential Revision: D67867310 Pulled By: kevinwilfong fbshipit-source-id: 14b18faa7b46802741b58de4ca5e03d5979137d4
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)