-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Register Spark array_join function #11948
Conversation
✅ Deploy Preview for meta-velox canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks this is missed in refactor
Just wondering which refactor it refers to, as we might also need to confirm the other missing cases if so.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
fdace9f
to
0a2c884
Compare
0a2c884
to
9c7282d
Compare
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kevinwilfong merged this pull request in d5e330b. |
Summary: Gluten removed the registration of Presto sql functions. This PR registers Presto array_join function in Spark for reuse. apache/incubator-gluten#2705 Pull Request resolved: facebookincubator#11948 Reviewed By: bikramSingh91 Differential Revision: D67867310 Pulled By: kevinwilfong fbshipit-source-id: 14b18faa7b46802741b58de4ca5e03d5979137d4
Gluten removed the registration of Presto sql functions. This PR registers
Presto array_join function in Spark for reuse.
apache/incubator-gluten#2705