[CELEBORN] CHCelebornColumnarShuffleWriter supports celeborn.client.spark.shuffle.writer to use memory sort shuffle in ClickHouse backend #6432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
SteNicholas
force-pushed
the
columnar-shuffle-writer
branch
3 times, most recently
from
f66fc65 to
77627ae
Compare
SteNicholas
changed the title
SteNicholas
force-pushed
the
columnar-shuffle-writer
branch
2 times, most recently
from
1c1e15a to
32de3ce
Compare
taiyang-li
requested changes
Jul 12, 2024
...orn/clickhouse/src/main/scala/org/apache/spark/shuffle/CHCelebornColumnarShuffleWriter.scala
Outdated
Show resolved
Hide resolved
SteNicholas
force-pushed
the
columnar-shuffle-writer
branch
from
32de3ce to
0ff415e
Compare
SteNicholas
force-pushed
the
columnar-shuffle-writer
branch
4 times, most recently
from
9bb96a1 to
c9ae706
Compare
…park.shuffle.writer to use memory sort shuffle in ClickHouse backend
SteNicholas
force-pushed
the
columnar-shuffle-writer
branch
from
c9ae706 to
9193878
Compare
yma11
added a commit
to yma11/gluten
that referenced
this pull request
Jul 15, 2024
…client.spark.shuffle.writer to use memory sort shuffle in ClickHouse backend (apache#6432)" This reverts commit 30bddd0.
yma11
added a commit
to yma11/gluten
that referenced
this pull request
Jul 15, 2024
…client.spark.shuffle.writer to use memory sort shuffle in ClickHouse backend (apache#6432)" This reverts commit 30bddd0.
weiting-chen
pushed a commit
to weiting-chen/gluten
that referenced
this pull request
Nov 12, 2024
…park.shuffle.writer to use memory sort shuffle in ClickHouse backend (apache#6432)
weiting-chen
added a commit
that referenced
this pull request
Nov 18, 2024
* [CELEBORN] CHCelebornColumnarShuffleWriter supports celeborn.client.spark.shuffle.writer to use memory sort shuffle in ClickHouse backend (#6432) * [GLUTEN-6656][CELEBORN] Fix CelebornColumnarShuffleWriter assertion failed (#6657) --------- Co-authored-by: Nicholas Jiang <programgeek@163.com> Co-authored-by: exmy <xumovens@gmail.com>
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
CHCelebornColumnarShuffleWritersupportsceleborn.client.spark.shuffle.writerto use memory sort shuffle in ClickHouse backend.CHCelebornColumnarShuffleWriterinitializesnativeShuffleWriterwithout skippingColumnarBatchininternalWriteto avoid unnecessary creation ofnativeShuffleWriterfor skippingColumnarBatch.CHCelebornColumnarShuffleWriterandVeloxCelebornColumnarShuffleWriterintoCelebornColumnarShuffleWriter.How was this patch tested?
CI.