[CH][CELEBORN] CHCelebornColumnarShuffleWriter supports celeborn.client.spark.shuffle.writer to use memory sort shuffle in ClickHouse backend #6454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt.spark.shuffle.writer to use memory sort shuffle in ClickHouse backend
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
|
Ping @zzcclp, @taiyang-li. |
yma11
added a commit
to yma11/gluten
that referenced
this pull request
Jul 15, 2024
…orn.client.spark.shuffle.writer to use memory sort shuffle in ClickHouse backend (apache#6454)" This reverts commit de26785.
yma11
added a commit
to yma11/gluten
that referenced
this pull request
Jul 15, 2024
…orn.client.spark.shuffle.writer to use memory sort shuffle in ClickHouse backend (apache#6454)" This reverts commit de26785.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix #6432.
CHCelebornColumnarShuffleWritersupportsceleborn.client.spark.shuffle.writerto use memory sort shuffle in ClickHouse backend.CHCelebornColumnarShuffleWriterinitializesnativeShuffleWriterwithout skippingColumnarBatchininternalWriteto avoid unnecessary creation ofnativeShuffleWriterfor skippingColumnarBatch.CHCelebornColumnarShuffleWriterandVeloxCelebornColumnarShuffleWriterintoCelebornColumnarShuffleWriter.How was this patch tested?
CI.