chore: fix StringEncoding license & add multi license check action #227

simon824 · 2023-01-17T10:30:22Z

follow the apache/incubator-hugegraph#1632 (comment)

javeme · 2023-01-17T14:08:27Z

computer-core/src/main/java/org/apache/hugegraph/computer/core/util/StringEncoding.java

@@ -1,19 +1,3 @@
-/*


hi @WillemJiang can we keep both of the two licenses in a source file?

Did we make some big changes to the code？
If not，we cannot add copyright information to this file.

Thanks, about 60% of our own code is in this file.
The origin file is from:
https://github.com/JanusGraph/janusgraph/blob/83c93fe717453ec31086ca1a208217a747ebd1a8/janusgraph-core/src/main/java/org/janusgraph/util/encoding/StringEncoding.java#L26

WillemJiang · 2023-01-18T06:47:15Z

computer-core/src/main/java/org/apache/hugegraph/computer/core/util/StringEncoding.java

@@ -1,19 +1,3 @@
-/*


Did we make some big changes to the code？
If not，we cannot add copyright information to this file.

WillemJiang · 2023-01-18T06:50:50Z

NOTICE

+Apache Cassandra
+Copyright 2022 The Apache Software Foundation
+
+cassandra-hadoop-util/src/main/java/org/apache/cassandra/db/SystemKeyspace.java


We need to put this information into the License file instead of the NOTICE file.

These information in the NOTICE are copy from janusgraph NOTICE.txt.
It seems that the upstream NOTICE is not standardized, how should we deal with this situation?

I don't think we need to copy all these license-related information from janusgraph NOTICE file.

NOTICE

imbajin · 2023-01-18T17:47:40Z

Another question is:
Do we need to bring the reference information of the source code LICENSE in the root to dist/xx/LICENSE for the binary package?

Now we only include it in the source package's LICENSE

WillemJiang · 2023-01-19T11:02:41Z

Another question is: Do we need to bring the reference information of the source code LICENSE in the dist/xx/LICENSE of the binary package?

Now we only include it in the source package's LICENSE

Yes, we need to include the source code 'LICENSE' information in the binary release 'LICENSE'.

imbajin · 2023-02-08T10:12:08Z

LICENSE

+The following components are provided under the Apache License. See project link for details.
+The text of each license is the standard Apache 2.0 license.
+
+computer-core/src/main/java/org/apache/hugegraph/computer/core/util/StringEncoding.java files from https://github.com/JanusGraph


@javeme maybe this file should move to commons, so that we don't need to import the same refer in multi repo

I think it's ok

imbajin · 2023-02-08T10:26:10Z

computer-dist/release-docs/LICENSE

+Third party Go license
 ========================================================================

-The following components are provided under The Go licens.
+The following components are provided under The Go license.


@simon824 I correct the typo, ensure is this as expected?

imbajin · 2023-02-08T10:27:33Z

computer-core/src/main/java/org/apache/hugegraph/computer/core/util/StringEncoding.java

@@ -44,7 +28,6 @@

 /**
 * @author Matthias Broecheler (me@matthiasb.com)
- * @author HugeGraph Authors


I'm not sure whether we can add a new author, so temporarily remove it

Restore it after confirmation maybe

javeme · 2023-02-08T13:45:45Z

LICENSE

+The following components are provided under the Apache License. See project link for details.
+The text of each license is the standard Apache 2.0 license.
+
+computer-core/src/main/java/org/apache/hugegraph/computer/core/util/StringEncoding.java files from https://github.com/JanusGraph


I think it's ok

javeme · 2023-02-08T14:03:45Z

computer-core/src/main/java/org/apache/hugegraph/computer/core/util/StringEncoding.java

@@ -63,7 +46,7 @@ public final class StringEncoding {
    private static final Base64.Encoder BASE64_ENCODER = Base64.getEncoder();
    private static final Base64.Decoder BASE64_DECODER = Base64.getDecoder();

-    // Similar to {@link StringSerializer}
+    /** Similar to {@link StringSerializer} */


/* is ok?

/* is ok?

shouldn't use /* for class property, refer here

) * add license check action & use proper "UTF-8" charset * exclude generate go files * include release-docs in binary release * Update NOTICE --------- Co-authored-by: imbajin <jin@apache.org>

fix

464f233

This comment was marked as off-topic.

Sign in to view

javeme reviewed Jan 17, 2023

View reviewed changes

WillemJiang reviewed Jan 18, 2023

View reviewed changes

imbajin mentioned this pull request Jan 19, 2023

[Summary] computer release v1.0 todo list #188

Closed

14 tasks

imbajin added the apache label Jan 19, 2023

imbajin added this to the 1.0.0 milestone Jan 19, 2023

Update NOTICE

6ae93ff

imbajin changed the title ~~chore: fix StringEncoding license~~ chore: fix StringEncoding license & add multi license check action Feb 8, 2023

imbajin reviewed Feb 8, 2023

View reviewed changes

imbajin force-pushed the fixlic branch from 1eaf85b to 7805380 Compare February 8, 2023 10:29

add license check action & use proper "UTF-8" charset

8260690

imbajin force-pushed the fixlic branch from 7805380 to 8260690 Compare February 8, 2023 10:33

imbajin added 2 commits February 8, 2023 18:37

exclude generate go files

e654724

Merge branch 'master' into pr/227

a5876f6

javeme previously approved these changes Feb 8, 2023

View reviewed changes

include release-docs in binary release

5f0ee68

imbajin dismissed javeme’s stale review via 5f0ee68 February 8, 2023 13:54

javeme previously approved these changes Feb 8, 2023

View reviewed changes

Update NOTICE

85ccbd4

simon824 dismissed javeme’s stale review via 85ccbd4 February 9, 2023 08:22

imbajin approved these changes Feb 9, 2023

View reviewed changes

corgiboygsj approved these changes Feb 9, 2023

View reviewed changes

imbajin merged commit b1f7346 into apache:master Feb 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: fix StringEncoding license & add multi license check action #227

chore: fix StringEncoding license & add multi license check action #227

simon824 commented Jan 17, 2023 •

edited by imbajin

Loading

This comment was marked as off-topic.

javeme Jan 17, 2023

WillemJiang Jan 18, 2023

javeme Jan 18, 2023

WillemJiang Jan 18, 2023

WillemJiang Jan 18, 2023

simon824 Jan 18, 2023

WillemJiang Jan 19, 2023

imbajin commented Jan 18, 2023 •

edited

Loading

WillemJiang commented Jan 19, 2023

imbajin Feb 8, 2023

javeme Feb 8, 2023

imbajin Feb 8, 2023

imbajin Feb 8, 2023

javeme Feb 8, 2023

javeme Feb 8, 2023

imbajin Feb 8, 2023

chore: fix StringEncoding license & add multi license check action #227

chore: fix StringEncoding license & add multi license check action #227

Conversation

simon824 commented Jan 17, 2023 • edited by imbajin Loading

This comment was marked as off-topic.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imbajin commented Jan 18, 2023 • edited Loading

WillemJiang commented Jan 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simon824 commented Jan 17, 2023 •

edited by imbajin

Loading

imbajin commented Jan 18, 2023 •

edited

Loading