refact: use standard UTF-8 charset & enhance CI configs #2095

imbajin · 2023-01-19T10:13:48Z

follow the #1632 , and also fix some tiny problem

@zyxxoo could follow this PR to solve the TODOs

also fix some tiny problem

hugegraph-core/src/main/java/org/apache/hugegraph/backend/id/SnowflakeIdGenerator.java

hugegraph-core/src/main/java/org/apache/hugegraph/traversal/optimize/HugeScriptTraversal.java

hugegraph-api/src/main/java/org/apache/hugegraph/api/job/GremlinAPI.java

hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/AnsjAnalyzer.java

hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/HanLPAnalyzer.java

hugegraph-core/src/main/java/org/apache/hugegraph/type/Nameable.java

hugegraph-core/src/main/java/org/apache/hugegraph/type/define/Cardinality.java

hugegraph-core/src/main/java/org/apache/hugegraph/util/CompressUtil.java

hugegraph-core/src/main/java/org/apache/hugegraph/util/GZipUtil.java

hugegraph-core/src/main/java/org/apache/hugegraph/util/StringEncoding.java

...aph-cassandra/src/main/java/org/apache/hugegraph/backend/store/cassandra/CassandraShard.java

imbajin · 2023-02-01T17:07:23Z

TODO: move RAT(check) from build action --> check-license action (fix in #2103)

hugegraph-test/src/main/java/org/apache/hugegraph/tinkerpop/ProcessBasicSuite.java

hugegraph-test/src/main/java/org/apache/hugegraph/tinkerpop/StructureBasicSuite.java

...aph-cassandra/src/main/java/org/apache/hugegraph/backend/store/cassandra/CassandraShard.java

hugegraph-core/src/main/java/org/apache/hugegraph/util/StringEncoding.java

javeme · 2023-02-09T12:48:29Z

hugegraph-core/src/main/java/org/apache/hugegraph/util/StringEncoding.java

-        return buf.bytes();
+        try (BytesBuffer buf = LZ4Util.compress(encode(value), BLOCK_SIZE, bufferRatio)) {
+            return buf.bytes();
+        } catch (IOException e) {


seems don't need to catch IOException

the IOException throws by LZ4Util.compress/decompress & we just auto release the BytesBuffer when it used up, so if we don't catch exception, we need to throws out? (so as the decompress

yes just remove the catch, since the LZ4Util.compress already transfer IOException to BackendException

yes just remove the catch, since the LZ4Util.compress already transfer IOException to BackendException

�so shall we close the ByteBuffer when it used up? if we remove catch with try(xx), we need throws the exception?

It means we just ignore the ByteBuffer close?

yes the BytesBuffer don't need to close, it's just a memory buffer

yes the BytesBuffer don't need to close, it's just a memory buffer

OK, my previous consideration is that if the buffer is large(like compress a big file), we should recycle it manually in time to reduce the pressure of GC & memory usage, but lack enough validation, so back off for now

hugegraph-core/src/main/java/org/apache/hugegraph/util/StringEncoding.java

javeme · 2023-03-02T13:18:03Z

hugegraph-core/src/main/java/org/apache/hugegraph/util/StringEncoding.java

-        return buf.bytes();
+        try (BytesBuffer buf = LZ4Util.compress(encode(value), BLOCK_SIZE, bufferRatio)) {
+            return buf.bytes();
+        } catch (IOException e) {


yes just remove the catch, since the LZ4Util.compress already transfer IOException to BackendException

…nto fix-license

refact: mark TODO in the license problem code & use standard UTF-8

3694974

also fix some tiny problem

imbajin added dependencies Incompatible dependencies of package apache labels Jan 19, 2023

imbajin added this to the 1.0.0 milestone Jan 19, 2023

imbajin requested review from javeme and zyxxoo January 19, 2023 10:13

imbajin linked an issue Jan 19, 2023 that may be closed by this pull request

[Apache] check for license conflicts #1632

Closed

imbajin removed a link to an issue Jan 19, 2023

[Apache] check for license conflicts #1632

Closed

This comment was marked as off-topic.

Sign in to view

imbajin mentioned this pull request Jan 19, 2023

chore: fix snowflake license #2093

Merged

zyxxoo reviewed Jan 20, 2023

View reviewed changes

javeme reviewed Jan 21, 2023

View reviewed changes

...aph-cassandra/src/main/java/org/apache/hugegraph/backend/store/cassandra/CassandraShard.java Show resolved Hide resolved

imbajin added 2 commits February 7, 2023 23:16

Merge branch 'master' into fix-license

b390406

Merge branch 'master' into fix-license

0f5f561

imbajin commented Feb 7, 2023

View reviewed changes

hugegraph-test/src/main/java/org/apache/hugegraph/tinkerpop/ProcessBasicSuite.java Outdated Show resolved Hide resolved

hugegraph-test/src/main/java/org/apache/hugegraph/tinkerpop/StructureBasicSuite.java Outdated Show resolved Hide resolved

This was referenced Feb 8, 2023

chore: fix StringEncoding license & add multi license check action apache/incubator-hugegraph-computer#227

Merged

chore(license): add ProcessBasicSuite and SturctureBasicSuite license #2106

Merged

Merge branch 'master' into fix-license

3e08521

javeme reviewed Feb 9, 2023

View reviewed changes

zyxxoo and others added 6 commits February 10, 2023 13:07

remove todo

bfb9c8d

remove todo

c043b27

remove todo

c76dd19

remove todo

a5e83b7

remove todo

0fe5087

Merge branch 'master' into fix-license

405ec6e

imbajin removed this from the 1.0.0 milestone Feb 10, 2023

imbajin added 2 commits March 2, 2023 14:48

Merge branch 'master' into fix-license

9f8f42e

split static import

40281a5

javeme reviewed Mar 2, 2023

View reviewed changes

imbajin added 2 commits March 2, 2023 23:54

Update StringEncoding.java

170e550

Merge branch 'master' into fix-license

57b809b

imbajin changed the title ~~refact: mark TODO in the license problem code & use standard UTF-8~~ refact: use standard UTF-8 in string code operation Mar 2, 2023

imbajin requested a review from z7658329 March 2, 2023 15:57

imbajin added 2 commits March 3, 2023 15:49

chore: update the ci configs & enable license check as required

dddc823

Merge branch 'fix-license' of github.com:apache/incubator-hugegraph i…

d804d2f

…nto fix-license

imbajin changed the title ~~refact: use standard UTF-8 in string code operation~~ refact: use standard UTF-8 in string code operation & enhance CI configs Mar 3, 2023

imbajin changed the title ~~refact: use standard UTF-8 in string code operation & enhance CI configs~~ refact: use standard UTF-8 charset & enhance CI configs Mar 3, 2023

imbajin added 2 commits March 3, 2023 16:57

Update check-dependencies.yml

0d92f9c

Update check-dependencies.yml

c33adf7

javeme approved these changes Mar 6, 2023

View reviewed changes

zyxxoo approved these changes Mar 7, 2023

View reviewed changes

imbajin merged commit 6c0d596 into master Mar 7, 2023

imbajin deleted the fix-license branch March 7, 2023 15:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refact: use standard UTF-8 charset & enhance CI configs #2095

refact: use standard UTF-8 charset & enhance CI configs #2095

imbajin commented Jan 19, 2023 •

edited

Loading

This comment was marked as off-topic.

imbajin commented Feb 1, 2023 •

edited

Loading

javeme Feb 9, 2023

imbajin Mar 2, 2023

javeme Mar 2, 2023

imbajin Mar 2, 2023

javeme Mar 2, 2023

imbajin Mar 2, 2023 •

edited

Loading

javeme Mar 2, 2023

refact: use standard UTF-8 charset & enhance CI configs #2095

refact: use standard UTF-8 charset & enhance CI configs #2095

Conversation

imbajin commented Jan 19, 2023 • edited Loading

This comment was marked as off-topic.

imbajin commented Feb 1, 2023 • edited Loading

javeme Feb 9, 2023

Choose a reason for hiding this comment

imbajin Mar 2, 2023

Choose a reason for hiding this comment

javeme Mar 2, 2023

Choose a reason for hiding this comment

imbajin Mar 2, 2023

Choose a reason for hiding this comment

javeme Mar 2, 2023

Choose a reason for hiding this comment

imbajin Mar 2, 2023 • edited Loading

Choose a reason for hiding this comment

javeme Mar 2, 2023

Choose a reason for hiding this comment

imbajin commented Jan 19, 2023 •

edited

Loading

imbajin commented Feb 1, 2023 •

edited

Loading

imbajin Mar 2, 2023 •

edited

Loading