Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO ISSUE] Migrate to JUnit5 drools model #6128

Merged
merged 20 commits into from
Oct 17, 2024

Conversation

pibizza
Copy link
Contributor

@pibizza pibizza commented Oct 16, 2024

This PR is to migrate drools model to JUnit 5.

It does not include cleanups to assertj assertions because the PR is already large and I wanted to keep it focused on the migration.

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@mariofusco mariofusco merged commit 8b78f8a into apache:main Oct 17, 2024
7 of 9 checks passed
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Oct 24, 2024
* Migrated first parameter tests

* More tests migrated to JUnit5

* More tests migrated to JUnit5

* Infrastructure to migrate parameterized tests

* Migrated more tests

* More tests migrated

* Keep migrating

* Migrated more tests

* Migrated more tests

* Migrated more tests

* Migrated more tests

* Migrated even more tests

* Migrated more tests to JUnit5

* Migrated more tests. removed unused imports

* More tests migrated.

* More tests migrated to JUnit5

* Migrated more tests

* Migrated all the tests in model codegen

* All tests migrated to JUnit5

* Missed fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants