Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO ISSUE] Migrate to JUnit5 drools model #6128

Merged
merged 20 commits into from
Oct 17, 2024
Merged

[NO ISSUE] Migrate to JUnit5 drools model #6128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
de22135
Migrated first parameter tests
pibizza Oct 11, 2024
5040b3f
More tests migrated to JUnit5
pibizza Oct 11, 2024
7a08ae9
More tests migrated to JUnit5
pibizza Oct 11, 2024
ead1c58
Infrastructure to migrate parameterized tests
pibizza Oct 11, 2024
39de2e4
Migrated more tests
pibizza Oct 11, 2024
332425a
More tests migrated
pibizza Oct 11, 2024
930d0f4
Keep migrating
pibizza Oct 11, 2024
588af59
Migrated more tests
pibizza Oct 14, 2024
7df1b37
Migrated more tests
pibizza Oct 14, 2024
b85cea1
Migrated more tests
pibizza Oct 14, 2024
2ffecea
Migrated more tests
pibizza Oct 14, 2024
125b814
Migrated even more tests
pibizza Oct 14, 2024
6e745f9
Migrated more tests to JUnit5
pibizza Oct 16, 2024
3f97019
Migrated more tests. removed unused imports
pibizza Oct 16, 2024
8389051
More tests migrated.
pibizza Oct 16, 2024
6312441
More tests migrated to JUnit5
pibizza Oct 16, 2024
ae24c52
Migrated more tests
pibizza Oct 16, 2024
04376c4
Migrated all the tests in model codegen
pibizza Oct 16, 2024
74339cf
All tests migrated to JUnit5
pibizza Oct 16, 2024
cc65a25
Missed fix
pibizza Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions drools-model/drools-canonical-model/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,10 @@
<artifactId>logback-classic</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<scope>test</scope>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.assertj</groupId>
Expand Down
6 changes: 3 additions & 3 deletions .../drools-canonical-model/src/test/java/org/drools/model/operators/MatchesOperatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
*/
package org.drools.model.operators;

import org.junit.After;
import org.junit.Test;

import static org.assertj.core.api.Assertions.assertThat;

import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test;

public class MatchesOperatorTest {

Expand Down Expand Up @@ -60,7 +60,7 @@ public void testMatchesOperatorNoCache() {
assertThat(instance.mapSize()).isEqualTo(0);
}

@After
@AfterEach
public void resetCache() {
MatchesOperator instance = MatchesOperator.INSTANCE;
instance.reInitialize();
Expand Down
2 changes: 1 addition & 1 deletion ...s-model/drools-canonical-model/src/test/java/org/drools/model/util/OperatorUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

import java.math.BigDecimal;

import org.junit.Test;
import org.junit.jupiter.api.Test;

import static org.assertj.core.api.Assertions.assertThat;

Expand Down
32 changes: 6 additions & 26 deletions drools-model/drools-model-codegen/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,36 +127,16 @@
<scope>test</scope>
</dependency>

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-params</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.drools</groupId>
<artifactId>drools-decisiontables</artifactId>
Expand Down
Loading
Loading