DROOLS-1062 Reproducer for regression of ProjectClassLoader.getResources(). #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this PR is failing because it contains a reproducer for the regression but not a fix. |
ge0ffrey
changed the title
| KieContainer kieContainer = kieServices.newKieContainer(releaseId); | ||
|
|
||
| ClassLoader classLoader = kieContainer.getClassLoader(); | ||
| assertEnumerationSize(2, classLoader.getResources("org/drools/testdrl")); |
There was a problem hiding this comment.
This size should expect 1 instead of 2 (see screenshot of https://issues.jboss.org/browse/DROOLS-1062 for reason).
Currently it fails because the size is actually 0.
|
@mariofusco, @ge0ffrey I found the issue and a way to fix it. I will create a new PR with this test (fixed) and the proposed fix. |
|
I've created #644 which contains this reproducer + proposed fix. I believe this PR could be closed now. |
|
Merged by 55d6445e1 |
dupliaka
pushed a commit
to dupliaka/drools
that referenced
this pull request
Apr 1, 2022
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
cimbalek
pushed a commit
to cimbalek/incubator-kie-drools
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not include fix, only reproducer.