[DOOLS-1062] test case + proposed fix #644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -167,7 +167,7 @@ public boolean existsFolder(MemoryFolder folder) { | |||
| } | |||
|
|
|||
| public boolean existsFolder(String path) { | |||
| return folders.get( path ) != null; | |||
| return folders.get( path.length() > 0 ? MemoryFolder.trimLeadingAndTrailing( path ) : path ) != null; | |||
There was a problem hiding this comment.
NPE is lurking here. Are we 100 % sure path != null?
There was a problem hiding this comment.
Since the method is public we can never be sure. I don't know what caller could expect passing null (NPE?), but there should be no harm adding one more null check there.
psiroky
force-pushed
the
drools-1062-get-resources
branch
from
1fbf66f to
32c82be
Compare
|
+1 (only reviewed the tests) |
|
Merged by 55d6445e1 |
dupliaka
pushed a commit
to dupliaka/drools
that referenced
this pull request
Apr 1, 2022
…tence for Job Service (apache#644)
cimbalek
pushed a commit
to cimbalek/incubator-kie-drools
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mariofusco, @ge0ffrey this PR contains the test case from #643 and suggested fix in MemoryKieModule.
With these changes, those two failing optaplanner tests are now passing.