-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-issues#1575] Upgrade quarkus to 3.15 #3750
Conversation
7799cb6
to
e943195
Compare
The test failures are due to upgrade to infinispan and infinispan-protostream due to which it is throwing parse exception. see logs below. |
e943195
to
d0956e0
Compare
Hi @RishiRajAnand, please consider this #3785 when you finalize this effort. |
Test errors like this |
d0956e0
to
b3757fc
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3750 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3750/6/display/redirect Test results:
Those are the test failures: io.quarkus.it.kogito.devmode.DevMojoIT.testDRLHotReloadCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.io.quarkus.it.kogito.devmode.DevMojoIT.testDMNHotReloadCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.io.quarkus.it.kogito.devmode.DevMojoIT.testStaticResourceCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.io.quarkus.it.kogito.devmode.DevMojoIT.testBPMN2HotReloadCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.org.kie.kogito.quarkus.workflows.ConversationFlowIT.sanityVerification1 expectation failed.Expected status code <201> but was <400>. |
a338eb3
to
155a03e
Compare
155a03e
to
5f1b172
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3750 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3750/8/display/redirect Test results:
Those are the test failures: org.kie.kogito.codegen.tests.PublishEventIT.testBasicUserTaskProcessAbortexpected: "UserTasksProcess" but was: "defaultPackage.TimerProcess" io.quarkus.it.kogito.devmode.DevMojoIT.testDRLHotReloadCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.io.quarkus.it.kogito.devmode.DevMojoIT.testDMNHotReloadCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.io.quarkus.it.kogito.devmode.DevMojoIT.testStaticResourceCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.io.quarkus.it.kogito.devmode.DevMojoIT.testBPMN2HotReloadCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.org.kie.kogito.quarkus.workflows.ConversationFlowIT.sanityVerification1 expectation failed.Expected status code <201> but was <400>. |
5f1b172
to
56c1aea
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3750 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3750/9/display/redirect Test results:
Those are the test failures: io.quarkus.it.kogito.devmode.DevMojoIT.testDRLHotReloadCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.io.quarkus.it.kogito.devmode.DevMojoIT.testDMNHotReloadCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.io.quarkus.it.kogito.devmode.DevMojoIT.testStaticResourceCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.io.quarkus.it.kogito.devmode.DevMojoIT.testBPMN2HotReloadCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.org.kie.kogito.quarkus.workflows.ConversationFlowIT.sanityVerification1 expectation failed.Expected status code <201> but was <400>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure adding the flyway-postgres to the common flyway addon is the way to go.
Also take a look regarding import organization
@@ -41,7 +41,10 @@ | |||
<groupId>org.flywaydb</groupId> | |||
<artifactId>flyway-core</artifactId> | |||
</dependency> | |||
|
|||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, here we are adding a flyway dependency intended for a particular db in a common addon. I do not think thats the way to go. Im afraid this has to be moved somewhere else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fjtirado the problem here is that flyway has changed a bit between v9 and v10. In v9 the core module was including the support for almost all db like pgsql, h2, mysql... but other propietary db'a (like sql server) had its own flyway-database-<vendor>
maven module that should be manually included in the application pom.xml. In v10 they trimmed a bit more the flyway-core module, leaving only H2 and SQL Lite. So to allow Flyway work with any specific DB that isn't H2/SQL Lite it will be required adding the specific supporting database module.
In this module we had to include the flyway-database-postgresql
to allow the tests pass.
.../java/org/kie/kogito/codegen/process/persistence/marshaller/AbstractMarshallerGenerator.java
Outdated
Show resolved
Hide resolved
56c1aea
to
8eefc7e
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3750 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3750/10/display/redirect Test results:
Those are the test failures: io.quarkus.it.kogito.devmode.DevMojoIT.testDRLHotReload1 expectation failed.Expected status code <200> but was <404>. io.quarkus.it.kogito.devmode.DevMojoIT.testDMNHotReload1 expectation failed.Expected status code <200> but was <404>. io.quarkus.it.kogito.devmode.DevMojoIT.testStaticResource1 expectation failed.Expected status code <200> but was <404>. io.quarkus.it.kogito.devmode.DevMojoIT.testBPMN2HotReload1 expectation failed.Expected status code <201> but was <404>. org.kie.kogito.quarkus.workflows.ConversationFlowIT.sanityVerification1 expectation failed.Expected status code <201> but was <400>. |
35702e6
to
c51456b
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3750 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3750/16/display/redirect Test results:
Those are the test failures: org.kie.kogito.codegen.tests.PublishEventIT.testServiceTaskProcessWithErrorExpected size: 1 but was: 2 in: [ProcessInstanceStateDataEvent {specVersion=1.0, id='06dd06d1-07a3-4efa-a9fc-d6f13731d6d4', source=http://myhost/TimerProcess, type='ProcessInstanceStateDataEvent', time=2025-01-02T05:09:57.950050638-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceStateEventBody [eventDate=Thu Jan 02 05:09:57 EST 2025, eventUser=null, eventType=1, processId=defaultPackage.TimerProcess, processVersion=1.0, processType=BPMN, processInstanceId=42c85b0c-17ad-4862-874d-e8b6735ff21b, businessKey=null, processName=TimerProcess, parentInstanceId=null, rootProcessId=null, rootProcessInstanceId=null, state=1, roles=null], kogitoProcessInstanceId='42c85b0c-17ad-4862-874d-e8b6735ff21b', kogitoRootProcessInstanceId='null', kogitoProcessId='defaultPackage.TimerProcess', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=42c85b0c-17ad-4862-874d-e8b6735ff21b, kogitoprocist=1, kogitoprocversion=1.0, kogitoprocid=defaultPackage.TimerProcess, kogitoaddons=test}}, ProcessInstanceStateDataEvent {specVersion=1.0, id='00bf45a4-84e5-42db-83d2-2ee8757564b1', source=http://myhost/ServiceProcessDifferentOperations, type='ProcessInstanceStateDataEvent', time=2025-01-02T05:09:57.954078345-05:00, subject='null', dataContentType='application/json', dataSchema=null, data=ProcessInstanceStateEventBody [eventDate=Thu Jan 02 05:09:57 EST 2025, eventUser=null, eventType=1, processId=ServiceProcessDifferentOperations, processVersion=1.0, processType=BPMN, processInstanceId=8797819f-dcd7-417f-bb45-55d535c79462, businessKey=null, processName=Service Process, parentInstanceId=null, rootProcessId=null, rootProcessInstanceId=null, state=5, roles=null], kogitoProcessInstanceId='8797819f-dcd7-417f-bb45-55d535c79462', kogitoRootProcessInstanceId='null', kogitoProcessId='ServiceProcessDifferentOperations', kogitoRootProcessId='null', kogitoAddons='test', kogitoIdentity='null', extensionAttributes={kogitoproctype=BPMN, kogitoprocinstanceid=8797819f-dcd7-417f-bb45-55d535c79462, kogitoprocist=5, kogitoprocversion=1.0, kogitoprocid=ServiceProcessDifferentOperations, kogitoaddons=test}}] io.quarkus.it.kogito.devmode.DevMojoIT.testDRLHotReload1 expectation failed.Expected status code <200> but was <404>. io.quarkus.it.kogito.devmode.DevMojoIT.testDMNHotReload1 expectation failed.Expected status code <200> but was <404>. io.quarkus.it.kogito.devmode.DevMojoIT.testStaticResource1 expectation failed.Expected status code <200> but was <404>. io.quarkus.it.kogito.devmode.DevMojoIT.testBPMN2HotReloadCondition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes. |
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3750 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3750/17/display/redirect Test results:
Those are the test failures: io.quarkus.it.kogito.devmode.DevMojoIT.testDRLHotReload1 expectation failed.Expected status code <200> but was <404>. io.quarkus.it.kogito.devmode.DevMojoIT.testDMNHotReload1 expectation failed.Expected status code <200> but was <404>. io.quarkus.it.kogito.devmode.DevMojoIT.testStaticResource1 expectation failed.Expected status code <200> but was <404>. io.quarkus.it.kogito.devmode.DevMojoIT.testBPMN2HotReload1 expectation failed.Expected status code <201> but was <404>. org.kie.kogito.quarkus.workflows.AsyncAPIIT.testConsumerjava.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for detailsorg.kie.kogito.quarkus.workflows.EmitEnumRPCGreetIT.testStateIsUnknownjava.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details |
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3750 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3750/18/display/redirect Test results:
Those are the test failures: io.quarkus.it.kogito.devmode.DevMojoIT.testDRLHotReload1 expectation failed.Expected status code <200> but was <404>. io.quarkus.it.kogito.devmode.DevMojoIT.testDMNHotReload1 expectation failed.Expected status code <200> but was <404>. io.quarkus.it.kogito.devmode.DevMojoIT.testStaticResource1 expectation failed.Expected status code <200> but was <404>. io.quarkus.it.kogito.devmode.DevMojoIT.testBPMN2HotReload1 expectation failed.Expected status code <201> but was <404>. org.kie.kogito.quarkus.workflows.AsyncAPIIT.testConsumerjava.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for detailsorg.kie.kogito.quarkus.workflows.EmitEnumRPCGreetIT.testStateIsUnknownjava.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details |
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3750 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3750/19/display/redirect Test results:
Those are the test failures: io.quarkus.it.kogito.devmode.DevMojoIT.testDRLHotReload1 expectation failed.Expected status code <200> but was <404>. io.quarkus.it.kogito.devmode.DevMojoIT.testDMNHotReload1 expectation failed.Expected status code <200> but was <404>. io.quarkus.it.kogito.devmode.DevMojoIT.testStaticResource1 expectation failed.Expected status code <200> but was <404>. io.quarkus.it.kogito.devmode.DevMojoIT.testBPMN2HotReload1 expectation failed.Expected status code <201> but was <404>. |
26e0c3f
to
6931b3e
Compare
6931b3e
to
8b31bb0
Compare
- Adding `flyway-database-postgresql`
@@ -51,6 +51,11 @@ | |||
<type>pom</type> | |||
<scope>test</scope> | |||
</dependency> | |||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fjtirado same here, adding it for testing purposes.
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3750 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3750/34/display/redirect Test results:
Those are the test failures: org.kie.kogito.codegen.tests.PublishEventIT.testCompensationProcessExpected size: 9 but was: 11 in: [ProcessInstanceNodeEventBody [eventDate=Tue Jan 28 02:48:40 EST 2025, eventUser=null, eventType=2, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=42ce36a8-8087-4081-a13b-32fa7a0c43ae, connectionNodeInstanceId=SequenceFlow_1, nodeDefinitionId=_E76AD186-6FA6-4378-B45B-C8F73E2C497C, nodeName=timer fired, nodeType=ActionNode, nodeInstanceId=7926c12b-4105-486c-a919-53c56136821d, data={}], ProcessInstanceNodeEventBody [eventDate=Tue Jan 28 02:48:40 EST 2025, eventUser=null, eventType=2, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=42ce36a8-8087-4081-a13b-32fa7a0c43ae, connectionNodeInstanceId=SequenceFlow_2, nodeDefinitionId=_F9AC8B12-8E75-49B5-B799-292F66270627, nodeName=start, nodeType=StartNode, nodeInstanceId=4b8f0abf-bc3d-4ea8-9c9c-c55909fe86ac, data={}], ProcessInstanceNodeEventBody [eventDate=Tue Jan 28 02:48:40 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=1f5f4a63-8bbf-4b6f-93d5-a2d52a6a64bb, connectionNodeInstanceId=null, nodeDefinitionId=_B580FC2E-3924-472A-BCFB-A2ACBADA2B94, nodeName=Compensation 2, nodeType=ActionNode, nodeInstanceId=10507b26-5fbb-44bb-9e61-70f56431e760, data={}], ProcessInstanceNodeEventBody [eventDate=Tue Jan 28 02:48:40 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=1f5f4a63-8bbf-4b6f-93d5-a2d52a6a64bb, connectionNodeInstanceId=, nodeDefinitionId=_3F8F7865-7B32-4E44-B323-44CCBFC96C8F, nodeName=BoundaryEvent, nodeType=BoundaryEventNode, nodeInstanceId=09664398-12be-44b8-ad19-f70f1752cf5d, data={}], ProcessInstanceNodeEventBody [eventDate=Tue Jan 28 02:48:40 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=1f5f4a63-8bbf-4b6f-93d5-a2d52a6a64bb, connectionNodeInstanceId=null, nodeDefinitionId=_D91EB7E7-A287-4958-BF8E-27E364349BE9, nodeName=Compensation, nodeType=ActionNode, nodeInstanceId=d7a5e530-5d51-4b92-8e94-be0430b47f14, data={}], ProcessInstanceNodeEventBody [eventDate=Tue Jan 28 02:48:40 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=1f5f4a63-8bbf-4b6f-93d5-a2d52a6a64bb, connectionNodeInstanceId=, nodeDefinitionId=_C9728638-4D98-4C28-972D-C8C5A7CA0290, nodeName=BoundaryEvent, nodeType=BoundaryEventNode, nodeInstanceId=2fcba6e7-ef04-4f53-85a6-7bba6e418ff7, data={}], ProcessInstanceNodeEventBody [eventDate=Tue Jan 28 02:48:40 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=1f5f4a63-8bbf-4b6f-93d5-a2d52a6a64bb, connectionNodeInstanceId=null, nodeDefinitionId=_E38F40D5-3A9A-4332-A4DC-CE0A2D37E179, nodeName=End, nodeType=EndNode, nodeInstanceId=1bd33912-42a6-49c2-a2a8-386bc71dc302, data={}], ProcessInstanceNodeEventBody [eventDate=Tue Jan 28 02:48:40 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=1f5f4a63-8bbf-4b6f-93d5-a2d52a6a64bb, connectionNodeInstanceId=_457153B3-F67D-4D9F-ABF8-FFD10B6D934C, nodeDefinitionId=_CC9F5867-27CF-42CF-8838-648F44FD4CF1, nodeName=Compensate all tasks, nodeType=ActionNode, nodeInstanceId=c0d2a155-b742-48ae-a21d-8f3f246c8ac2, data={}], ProcessInstanceNodeEventBody [eventDate=Tue Jan 28 02:48:40 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=1f5f4a63-8bbf-4b6f-93d5-a2d52a6a64bb, connectionNodeInstanceId=_ACA65ACF-CBDA-4452-8C1A-609D54F1B749, nodeDefinitionId=_AA20EA8B-91E3-4171-8345-BFFBB103CD7F, nodeName=ScriptTask2, nodeType=ActionNode, nodeInstanceId=754f5ea4-21d5-4e42-bff2-9f2d61b55cc4, data={}], ProcessInstanceNodeEventBody [eventDate=Tue Jan 28 02:48:40 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=1f5f4a63-8bbf-4b6f-93d5-a2d52a6a64bb, connectionNodeInstanceId=_FF746A9A-D85F-4A83-918B-64808ACDE8E6, nodeDefinitionId=_8B1500BC-7458-4BFA-AB61-CC3AF6F375F9, nodeName=ScriptTask, nodeType=ActionNode, nodeInstanceId=72009f46-5050-472b-b9de-74d28651e837, data={}], ProcessInstanceNodeEventBody [eventDate=Tue Jan 28 02:48:40 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=1f5f4a63-8bbf-4b6f-93d5-a2d52a6a64bb, connectionNodeInstanceId=_66C7CEB0-2A49-4328-9E9D-0AD75C898486, nodeDefinitionId=_8AD8A66C-6327-4F26-BB2E-314283BED823, nodeName=Start, nodeType=StartNode, nodeInstanceId=c99623a9-cccf-4156-b5b0-eb1ab47db183, data={}]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pefernan Thanks for the explanation.
I feel the test should be probably moved to a different module, but to be fair, the pgsql depeendencias are test scope and we had the same situation in may other places (and at the end, is not a big deal as far as the dependency is test scope, as it is the case)
So, lets move forward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RishiRajAnand ! LGTM
Closes: apache/incubator-kie-issues#1575
Related PRs:
apache/incubator-kie-drools#6131
apache/incubator-kie-optaplanner#3134
apache/incubator-kie-kogito-apps#2141
apache/incubator-kie-kogito-examples#2038
<quarkus.package.type>native</quarkus.package.type>
renamed to<quarkus.native.enabled>true</quarkus.native.enabled>
Many thanks for submitting your Pull Request ❤️!
Closes/Fixes/Resolves #ISSUE-NUMBER
Description:
Please make sure that your PR meets the following requirements:
Issue-XYZ Subject
[0.9.x] Issue-XYZ Subject
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.