-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOGITO-9428]Update Operator SDK from 1.25 to 1.31 #165
base: main
Are you sure you want to change the base?
Conversation
/hold |
5e27a30
to
0cd54bf
Compare
@@ -262,7 +262,7 @@ bundle-build: ## Build the bundle image. | |||
|
|||
.PHONY: bundle-push | |||
bundle-push: ## Push the bundle image. | |||
$(MAKE) contianer-push IMG=$(BUNDLE_IMG) | |||
$(MAKE) container-push IMG=$(BUNDLE_IMG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems simple enough 🤔
We can merge this after 1.41.x release since we might cherrypick/fix bugs for TP1 up until there. It will be easier for us if the SDK version remains the same for this work.
8d89a7f
to
ea851a7
Compare
Please hold until #185 |
hack/check-created-at-annotation.sh
Outdated
check_file=$(expr "$changed_files" == "M bundle/manifests/sonataflow-operator.clusterserviceversion.yaml") | ||
|
||
if [[ "$check_file" == "0" ]] ; then | ||
##@TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
letfover ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, fixed
changed_files=$(git status -s) | ||
check_file=$(expr "$changed_files" == "M bundle/manifests/sonataflow-operator.clusterserviceversion.yaml") | ||
|
||
if [[ "$check_file" == "0" ]] ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is the specific use case where only that file is changed right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a small comment on what it does ? (apart from the issues above)
Signed-off-by: desmax74 <mdessi@redhat.com>
Signed-off-by: desmax74 <mdessi@redhat.com>
Signed-off-by: desmax74 <mdessi@redhat.com>
can we hold until we get https://github.com/kiegroup/kogito-serverless-operator/pull/239 merged? |
Signed-off-by: Karel Suta <ksuta@redhat.com>
@ricardozanini looks stale, how to proceed with this PR? |
This is relevant, but I'm holding off until we settle on the features being introduced at the moment. There are many requests for features atm and upgrading the base SDK may lead to many errors since we have many collaborators atm. |
The code base changed a lot from this last iteration. @desmax74 do you think you can rebase? Otherwise, I'll upgrade to the latest in a new PR. |
See: https://issues.redhat.com/browse/KOGITO-9428
and related:
operator-framework/operator-sdk#6285
operator-framework/operator-sdk#6419
Description of the change:
Motivation for the change:
Checklist
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.