Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KOGITO-9417] Introduce workflowproj-apiserver #185

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ricardozanini
Copy link
Member

Description of the change:
See: https://issues.redhat.com/browse/KOGITO-9417

Draft/Design stage, please don't review.

Motivation for the change:

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@apache apache deleted a comment from kie-ci Jul 18, 2023
@apache apache deleted a comment from kie-ci Jul 18, 2023
@apache apache deleted a comment from kie-ci Jul 18, 2023
@kie-ci

This comment was marked as outdated.

@kie-ci

This comment was marked as outdated.

@kie-ci

This comment was marked as outdated.

@kie-ci

This comment was marked as outdated.

@radtriste
Copy link
Contributor

@ricardozanini enjoy the GHA fix :)

@caponetto
Copy link

Hi @ricardozanini,
Thanks for putting this together!

I gave it a try, following these steps:

  1. Create a sonataflowproj named test
  2. 1st upload to test a zip containing the hello workflow -> a new set of deployment/service/route was created with the name hello
  3. 2nd upload to test a zip containing the jsongreet workflow -> a new set of deployment/service/route was created with the name jsongreet

It is expected that only one deployment/service/route set is created with the name test, right?
And this single deployment is updated after each upload to test.

@apache apache deleted a comment from kie-ci Sep 4, 2023
MarianMacik pushed a commit to MarianMacik/kogito-serverless-operator that referenced this pull request Oct 3, 2023
* Refactored and factorized cr & cli steps/framework

* updates
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
@ricardozanini ricardozanini marked this pull request as ready for review November 23, 2023 19:25
@ricardozanini
Copy link
Member Author

@caponetto for a tech preview, I think we are there. Let me know when you will have time to test with Kubesmarts.

@apache apache deleted a comment from kie-ci Nov 23, 2023
@apache apache deleted a comment from kie-ci Nov 23, 2023
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
@domhanak
Copy link
Contributor

@ricardozanini is this still relevant?

@ricardozanini
Copy link
Member Author

@ricardozanini is this still relevant?

Yes. We had other priorities, but we will eventually get back to it for Kubesmarts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants