Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor throttle_test and reduce the consumption of disk space #1534

Closed
empiredan opened this issue Jun 14, 2023 · 0 comments
Closed

Refactor throttle_test and reduce the consumption of disk space #1534

empiredan opened this issue Jun 14, 2023 · 0 comments
Labels
type/enhancement Indicates new feature requests

Comments

@empiredan
Copy link
Contributor

  • refactor the code of throttle_test;
  • at the end of each test case, stop onebox for each replica server and clear the data to release the disk space.
@empiredan empiredan added the type/enhancement Indicates new feature requests label Jun 14, 2023
@empiredan empiredan mentioned this issue Jun 14, 2023
Merged
empiredan added a commit that referenced this issue Jun 14, 2023
@empiredan
fix(github): throttle_test failed frequently due to insufficient disk…
96116f6 
… space (#1530)

#1529

Options used by onebox and function tests are made configurable. The default
values for these options are unchanged. Once custom options are provided as
the arguments of `run.sh`, these custom options would be used to substitute
for the current configurations. Github workflow for cpp has used custom options
to reduce the consumption of disk space.

On the other hand, to solve the problem that `throttle_test` failed frequently
fundamentally, `throttle_test` should be refactored: at the end of each test
case, onebox for each replica server should be stopped and the data should
be cleared to release the disk space. This is tracked by another issue:
        #1534
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@empiredan @acelyc111