Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): throttle_test failed frequently due to insufficient disk space #1530

Merged
merged 4 commits into from
Jun 14, 2023

Conversation

empiredan
Copy link
Contributor

@empiredan empiredan commented Jun 12, 2023

#1529

Options used by onebox and function tests are made configurable. The default
values for these options are unchanged. Once custom options are provided as
the arguments of run.sh, these custom options would be used to substitute
for the current configurations. Github workflow for cpp has used custom options
to reduce the consumption of disk space.

On the other hand, to solve the problem that throttle_test failed frequently
fundamentally, throttle_test should be refactored: at the end of each test
case, onebox for each replica server should be stopped and the data should
be cleared to release the disk space. This is tracked by another issue:
#1534

@cr-gpt
Copy link

cr-gpt bot commented Jun 13, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@github-actions github-actions bot added the cpp label Jun 13, 2023
@cr-gpt
Copy link

cr-gpt bot commented Jun 13, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@cr-gpt
Copy link

cr-gpt bot commented Jun 13, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@empiredan empiredan merged commit 96116f6 into apache:master Jun 14, 2023
@empiredan empiredan mentioned this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants