optimize: remove fst serialization (#6002)

apache · Nov 12, 2023 · bbbbec7 · bbbbec7
1 parent 1de3532
commit bbbbec7
Show file tree

Hide file tree

Showing 23 changed files with 17 additions and 483 deletions.
diff --git a/all/pom.xml b/all/pom.xml
@@ -254,11 +254,6 @@
             <artifactId>seata-serializer-kryo</artifactId>
             <version>${project.version}</version>
         </dependency>
-        <dependency>
-            <groupId>io.seata</groupId>
-            <artifactId>seata-serializer-fst</artifactId>
-            <version>${project.version}</version>
-        </dependency>
         <dependency>
             <groupId>io.seata</groupId>
             <artifactId>seata-serializer-hessian</artifactId>
@@ -586,11 +581,6 @@
             <artifactId>kryo</artifactId>
             <scope>provided</scope>
         </dependency>
-        <dependency>
-            <groupId>de.ruedigermoeller</groupId>
-            <artifactId>fst</artifactId>
-            <scope>provided</scope>
-        </dependency>
         <dependency>
             <groupId>com.dameng</groupId>
             <artifactId>DmJdbcDriver18</artifactId>

diff --git a/bom/pom.xml b/bom/pom.xml
@@ -270,11 +270,6 @@
                 <artifactId>seata-serializer-hessian</artifactId>
                 <version>${project.version}</version>
             </dependency>
-            <dependency>
-                <groupId>io.seata</groupId>
-                <artifactId>seata-serializer-fst</artifactId>
-                <version>${project.version}</version>
-            </dependency>
             <dependency>
                 <groupId>io.seata</groupId>
                 <artifactId>seata-spring-boot-starter</artifactId>

diff --git a/changes/en-us/2.0.0.md b/changes/en-us/2.0.0.md
@@ -149,6 +149,8 @@ The version is updated as follows:
 - [[#5938](https://github.com/seata/seata/pull/5938)] support jmx port in seata
 - [[#5951](https://github.com/seata/seata/pull/5951)] remove un support config in jdk17
 - [[#5959](https://github.com/seata/seata/pull/5959)] modify code style and remove unused import
+- [[#6002](https://github.com/seata/seata/pull/6002)] remove fst serialization
+
 
 ### security:
 - [[#5642](https://github.com/seata/seata/pull/5642)] add Hessian Serializer WhiteDenyList

diff --git a/changes/zh-cn/2.0.0.md b/changes/zh-cn/2.0.0.md
@@ -150,6 +150,7 @@ Seata 是一款开源的分布式事务解决方案，提供高性能和简单
 - [[#5938](https://github.com/seata/seata/pull/5938)] 支持 jmx 监控配置
 - [[#5951](https://github.com/seata/seata/pull/5951)] 删除在 jdk17 中不支持的配置项
 - [[#5959](https://github.com/seata/seata/pull/5959)] 修正代码风格问题及去除无用的类引用
+- [[#6002](https://github.com/seata/seata/pull/6002)] 移除fst序列化模块
 
 
 ### security:

diff --git a/core/src/main/java/io/seata/core/serializer/SerializerType.java b/core/src/main/java/io/seata/core/serializer/SerializerType.java
@@ -44,7 +44,7 @@ public enum SerializerType {
     KRYO((byte)0x4),
 
     /**
-     * The fst.
+     * The fst but it's been removed.
      * <p>
      * Math.pow(2, 3)
      */
@@ -56,8 +56,9 @@ public enum SerializerType {
      * Math.pow(2, 4)
      */
     HESSIAN((byte)0x16),
+
     /**
-     * The hessian.
+     * The jackson.
      * <p>
      * Math.pow(2, 5)
      */
@@ -82,6 +83,10 @@ public static SerializerType getByCode(int code) {
                 return b;
             }
         }
+        if (code == SerializerType.FST.getCode()) {
+            throw new IllegalArgumentException(
+                "Since fst is no longer maintained, this serialization extension has been removed from version 2.0 for security and stability reasons.");
+        }
         throw new IllegalArgumentException("unknown codec:" + code);
     }
 

diff --git a/dependencies/pom.xml b/dependencies/pom.xml
@@ -78,7 +78,6 @@
         <kryo.version>5.4.0</kryo.version>
         <kryo-serializers.version>0.45</kryo-serializers.version>
         <hessian.version>4.0.63</hessian.version>
-        <fst.version>2.57</fst.version>
         <groovy.version>2.4.4</groovy.version>
         <zstd.version>1.5.0-4</zstd.version>
         <xstream.version>1.4.20</xstream.version>
@@ -561,11 +560,6 @@
                 <artifactId>hessian</artifactId>
                 <version>${hessian.version}</version>
             </dependency>
-            <dependency>
-                <groupId>de.ruedigermoeller</groupId>
-                <artifactId>fst</artifactId>
-                <version>${fst.version}</version>
-            </dependency>
             <dependency>
                 <groupId>org.apache.commons</groupId>
                 <artifactId>commons-compress</artifactId>

diff --git a/rm-datasource/pom.xml b/rm-datasource/pom.xml
@@ -103,12 +103,6 @@
             <scope>provided</scope>
             <optional>true</optional>
         </dependency>
-        <dependency>
-            <groupId>de.ruedigermoeller</groupId>
-            <artifactId>fst</artifactId>
-            <scope>provided</scope>
-            <optional>true</optional>
-        </dependency>
         <dependency>
             <groupId>com.alibaba</groupId>
             <artifactId>fastjson</artifactId>

diff --git a/rm-datasource/src/main/java/io/seata/rm/datasource/undo/UndoLogParserFactory.java b/rm-datasource/src/main/java/io/seata/rm/datasource/undo/UndoLogParserFactory.java
@@ -17,6 +17,7 @@
 
 import io.seata.common.loader.EnhancedServiceLoader;
 import io.seata.common.util.CollectionUtils;
+import io.seata.common.util.StringUtils;
 
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ConcurrentMap;
@@ -58,6 +59,10 @@ public static UndoLogParser getInstance() {
      * @return the UndoLogParser
      */
     public static UndoLogParser getInstance(String name) {
+        if (StringUtils.equalsIgnoreCase("fst", name)) {
+            throw new IllegalArgumentException(
+                "Since fst is no longer maintained, this serialization extension has been removed from version 2.0 for security and stability reasons.");
+        }
         return CollectionUtils.computeIfAbsent(INSTANCES, name,
             key -> EnhancedServiceLoader.load(UndoLogParser.class, name));
     }

diff --git a/rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/FstSerializerFactory.java b/rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/FstSerializerFactory.java
diff --git a/rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/FstUndoLogParser.java b/rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/FstUndoLogParser.java
diff --git a/rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/spi/FstSerializer.java b/rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/spi/FstSerializer.java
diff --git a/rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.undo.UndoLogParser b/rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.undo.UndoLogParser
@@ -1,5 +1,4 @@
 io.seata.rm.datasource.undo.parser.FastjsonUndoLogParser
 io.seata.rm.datasource.undo.parser.JacksonUndoLogParser
 io.seata.rm.datasource.undo.parser.ProtostuffUndoLogParser
-io.seata.rm.datasource.undo.parser.KryoUndoLogParser
-io.seata.rm.datasource.undo.parser.FstUndoLogParser
+io.seata.rm.datasource.undo.parser.KryoUndoLogParser
diff --git a/rm-datasource/src/test/java/io/seata/rm/datasource/undo/UndoLogParserFactoryTest.java b/rm-datasource/src/test/java/io/seata/rm/datasource/undo/UndoLogParserFactoryTest.java
@@ -26,6 +26,7 @@ class UndoLogParserFactoryTest {
 
     @Test
     void getInstance() {
+        Assertions.assertThrowsExactly(IllegalArgumentException.class, () -> UndoLogParserFactory.getInstance("fst"));
         Assertions.assertTrue(UndoLogParserFactory.getInstance() instanceof JacksonUndoLogParser);
     }
 }
diff --git a/rm-datasource/src/test/java/io/seata/rm/datasource/undo/UndoLogParserProviderTest.java b/rm-datasource/src/test/java/io/seata/rm/datasource/undo/UndoLogParserProviderTest.java
@@ -21,7 +21,6 @@
 import io.seata.common.loader.EnhancedServiceLoader;
 import io.seata.common.loader.EnhancedServiceNotFoundException;
 import io.seata.rm.datasource.undo.parser.FastjsonUndoLogParser;
-import io.seata.rm.datasource.undo.parser.FstUndoLogParser;
 import io.seata.rm.datasource.undo.parser.JacksonUndoLogParser;
 import io.seata.rm.datasource.undo.parser.KryoUndoLogParser;
 import io.seata.rm.datasource.undo.parser.ProtostuffUndoLogParser;
@@ -45,10 +44,6 @@ void testLoad(){
         Assertions.assertNotNull(parser);
         Assertions.assertTrue(parser instanceof ProtostuffUndoLogParser);
 
-        parser = EnhancedServiceLoader.load(UndoLogParser.class, "fst");
-        Assertions.assertNotNull(parser);
-        Assertions.assertTrue(parser instanceof FstUndoLogParser);
-
         parser = EnhancedServiceLoader.load(UndoLogParser.class, "kryo");
         Assertions.assertNotNull(parser);
         Assertions.assertTrue(parser instanceof KryoUndoLogParser);