Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove fst serialization #6002

Merged
merged 13 commits into from
Nov 12, 2023
Merged

optimize: remove fst serialization #6002

merged 13 commits into from
Nov 12, 2023

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #5999

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.0.0 milestone Nov 6, 2023
@funky-eyes funky-eyes added module/rm-datasource rm-datasource module module/serializer serializer module type: optimize module/server server module module/core core module module/bom module/all and removed module/server server module labels Nov 6, 2023
ptyin pushed a commit to ptyin/seata that referenced this pull request Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #6002 (5602ce9) into 2.x (bc7d212) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6002      +/-   ##
============================================
- Coverage     49.59%   49.57%   -0.02%     
+ Complexity     4766     4747      -19     
============================================
  Files           911      907       -4     
  Lines         31316    31275      -41     
  Branches       3773     3770       -3     
============================================
- Hits          15530    15506      -24     
+ Misses        14253    14237      -16     
+ Partials       1533     1532       -1     
Files Coverage Δ
...seata/rm/datasource/undo/UndoLogParserFactory.java 100.00% <100.00%> (ø)
.../java/io/seata/core/serializer/SerializerType.java 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit bbbbec7 into apache:2.x Nov 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] remove low-security serializers that are no longer maintained
3 participants