-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: remove fst serialization #6002
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
added
module/rm-datasource
rm-datasource module
module/serializer
serializer module
type: optimize
module/server
server module
module/core
core module
module/bom
module/all
and removed
module/server
server module
labels
Nov 6, 2023
ptyin
pushed a commit
to ptyin/seata
that referenced
this pull request
Nov 6, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6002 +/- ##
============================================
- Coverage 49.59% 49.57% -0.02%
+ Complexity 4766 4747 -19
============================================
Files 911 907 -4
Lines 31316 31275 -41
Branches 3773 3770 -3
============================================
- Hits 15530 15506 -24
+ Misses 14253 14237 -16
+ Partials 1533 1532 -1
|
leizhiyuan
reviewed
Nov 7, 2023
core/src/main/java/io/seata/core/serializer/SerializerType.java
Outdated
Show resolved
Hide resolved
slievrly
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module/all
module/bom
module/core
core module
module/rm-datasource
rm-datasource module
module/seata-spring-autoconfigure-client
module/serializer
serializer module
type: optimize
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5999
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews