Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize derivative product check base on mysql #6044

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Nov 17, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize derivative product check base on mysql

Ⅱ. Does this pull request fix one issue?

fixes #6037

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

image
image

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #6044 (3cbca46) into develop (c829e73) will decrease coverage by 0.03%.
The diff coverage is 31.25%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #6044      +/-   ##
=============================================
- Coverage      48.88%   48.85%   -0.03%     
  Complexity      4186     4186              
=============================================
  Files            793      793              
  Lines          28028    28039      +11     
  Branches        3423     3426       +3     
=============================================
- Hits           13702    13699       -3     
- Misses         12897    12908      +11     
- Partials        1429     1432       +3     
Files Coverage Δ
...datasource/exec/mysql/MySQLUpdateJoinExecutor.java 77.07% <100.00%> (ø)
...n/java/io/seata/rm/datasource/DataSourceProxy.java 54.34% <29.03%> (-5.50%) ⬇️

... and 2 files with indirect coverage changes

Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.8.1 milestone Nov 17, 2023
@leizhiyuan leizhiyuan self-requested a review November 17, 2023 08:22
@slievrly slievrly merged commit c0c8725 into apache:develop Nov 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants