Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize derivative product check base on mysql #6045

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Nov 17, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize derivative product check base on mysql

Ⅱ. Does this pull request fix one issue?

cherry-pick #6044

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly added this to the 2.0.0 milestone Nov 17, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #6045 (ac0b41a) into 2.x (3e9a46e) will decrease coverage by 0.07%.
The diff coverage is 31.25%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6045      +/-   ##
============================================
- Coverage     49.61%   49.55%   -0.07%     
+ Complexity     4756     4749       -7     
============================================
  Files           907      907              
  Lines         31284    31295      +11     
  Branches       3770     3773       +3     
============================================
- Hits          15523    15508      -15     
- Misses        14235    14252      +17     
- Partials       1526     1535       +9     
Files Coverage Δ
...datasource/exec/mysql/MySQLUpdateJoinExecutor.java 77.07% <100.00%> (ø)
...n/java/io/seata/rm/datasource/DataSourceProxy.java 57.40% <29.03%> (-4.85%) ⬇️

... and 14 files with indirect coverage changes

@leizhiyuan leizhiyuan merged commit 545da73 into apache:2.x Nov 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants