Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3612 - reverse sign in difference calculation #3646

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Fix #3612 - reverse sign in difference calculation #3646

merged 1 commit into from
Oct 12, 2017

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Oct 11, 2017 •
edited
Loading

fixes #3612

@coveralls
Copy link

coveralls commented Oct 11, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 70.091% when pulling cdd5374 on mistercrunch:fix_diff into 4a3c091 on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.091% when pulling cdd5374 on mistercrunch:fix_diff into 4a3c091 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.091% when pulling cdd5374 on mistercrunch:fix_diff into 4a3c091 on apache:master.

@michellethomas
Copy link
Contributor

lgtm

@mistercrunch mistercrunch merged commit 3ebadbc into apache:master Oct 12, 2017
@mistercrunch mistercrunch deleted the fix_diff branch October 12, 2017 04:14
eddy-geek added a commit to eddy-geek/incubator-superset that referenced this pull request Oct 15, 2017
@eddy-geek
Merge remote-tracking branch 'remotes/origin/master' into filter_inpu…
609d1e2 
…t_box

* remotes/origin/master: (340 commits)
  [New Viz] Partition Diagram (apache#3642)
  Add description for running specific test (apache#3665)
  Making the sort order for metrics pull from fd for time table viz (apache#3661)
  Make columns that return an exception on click unsortable. (apache#3417)
  Adding sort time table (apache#3651)
  added aihello as superset user. (apache#3647)
  Fix apache#3612 - reverse sign in difference calculation (apache#3646)
  Fixing some warnings during tests (apache#3648)
  [Translations] Restored lost French translations (apache#3645)
  [sql lab] fix impersonation + template issue (apache#3644)
  Pin moment.js library since 2.19.0 creates problem (apache#3641)
  [time_table] adding support for URLs / links (apache#3600)
  Set tooltip to show extent of sparkData (apache#3626)
  add explicit message display for 'Fetching Annotation Layer' error (apache#3631)
  [bugfix] Template rendering failed: '_AppCtxGlobals' object has no attribute 'user' (apache#3637)
  fix long title text wrapping in editable-title component (apache#3638)
  [minor] proper tooltip on ControlHeader's instant re-render trigger (apache#3625)
  add annotation option and a linear color map for heatmap viz. (apache#3634)
  [bugfix] empty From date filter NoneType error (apache#3633)
  remove unused imports (apache#3621)
  ...
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch @michellethomas
Fix apache#3612 - reverse sign in difference calculation (apache#3646)
42772e3
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.5 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time Series Table: Difference calculation has wrong sign
3 participants
@mistercrunch @coveralls @michellethomas