Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add explicit message display for 'Fetching Annotation Layer' error #3631

Merged

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Oct 9, 2017

our users report seeing ERROR WHEN FETCHING ANNOTATION LAYER error but I can't reproduce. This is a code clean-up, and show more details in error message.

  1. add explicit message display if Fetching Annotation Layer error happens.
  2. split done, fail, always callback separately.

@coveralls
Copy link

coveralls commented Oct 9, 2017

Coverage Status

Coverage decreased (-0.3%) to 69.807% when pulling b89db56 on graceguo-supercat:gg-fixAnnotationLayerErrorMsg into 64ef8b1 on apache:master.

@mistercrunch
Copy link
Member

mistercrunch commented Oct 10, 2017

@graceguo-supercat PR is failing to building...

@mistercrunch mistercrunch merged commit bd45e3b into apache:master Oct 10, 2017
@mistercrunch mistercrunch deleted the gg-fixAnnotationLayerErrorMsg branch October 10, 2017 18:49
eddy-geek added a commit to eddy-geek/incubator-superset that referenced this pull request Oct 15, 2017
…t_box

* remotes/origin/master: (340 commits)
  [New Viz] Partition Diagram (apache#3642)
  Add description for running specific test (apache#3665)
  Making the sort order for metrics pull from fd for time table viz (apache#3661)
  Make columns that return an exception on click unsortable. (apache#3417)
  Adding sort time table (apache#3651)
  added aihello as superset user. (apache#3647)
  Fix apache#3612 - reverse sign in difference calculation (apache#3646)
  Fixing some warnings during tests (apache#3648)
  [Translations] Restored lost French translations (apache#3645)
  [sql lab] fix impersonation + template issue (apache#3644)
  Pin moment.js library since 2.19.0 creates problem (apache#3641)
  [time_table] adding support for URLs / links (apache#3600)
  Set tooltip to show extent of sparkData (apache#3626)
  add explicit message display for 'Fetching Annotation Layer' error (apache#3631)
  [bugfix] Template rendering failed: '_AppCtxGlobals' object has no attribute 'user' (apache#3637)
  fix long title text wrapping in editable-title component (apache#3638)
  [minor] proper tooltip on ControlHeader's instant re-render trigger (apache#3625)
  add annotation option and a linear color map for heatmap viz. (apache#3634)
  [bugfix] empty From date filter NoneType error (apache#3633)
  remove unused imports (apache#3621)
  ...
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.4 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants