Adding sort time table #3651
Merged
Adding sort time table #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eddy-geek
added a commit
to eddy-geek/incubator-superset
that referenced
this pull request
Oct 15, 2017
…t_box * remotes/origin/master: (340 commits) [New Viz] Partition Diagram (apache#3642) Add description for running specific test (apache#3665) Making the sort order for metrics pull from fd for time table viz (apache#3661) Make columns that return an exception on click unsortable. (apache#3417) Adding sort time table (apache#3651) added aihello as superset user. (apache#3647) Fix apache#3612 - reverse sign in difference calculation (apache#3646) Fixing some warnings during tests (apache#3648) [Translations] Restored lost French translations (apache#3645) [sql lab] fix impersonation + template issue (apache#3644) Pin moment.js library since 2.19.0 creates problem (apache#3641) [time_table] adding support for URLs / links (apache#3600) Set tooltip to show extent of sparkData (apache#3626) add explicit message display for 'Fetching Annotation Layer' error (apache#3631) [bugfix] Template rendering failed: '_AppCtxGlobals' object has no attribute 'user' (apache#3637) fix long title text wrapping in editable-title component (apache#3638) [minor] proper tooltip on ControlHeader's instant re-render trigger (apache#3625) add annotation option and a linear color map for heatmap viz. (apache#3634) [bugfix] empty From date filter NoneType error (apache#3633) remove unused imports (apache#3621) ...
michellethomas
added a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Updating time_table component to sort * Removing old sort
This was referenced Oct 6, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm enabling sorting on the time table visualization. Instead of just passing the component to row, I'm passing an object with the component to be displayed as well as the underlying data. Sending the data as value to
Tdallows reactable to sort by the data instead of the component that's getting displayed.By default it will sort by the first column in fd.column_collection and then users can toggle sort for any of the columns.
I noticed a few issues with reactable, created an issue here. If the user changes the first column (to adjust the sort), reactable doesn't correctly resort until the page is reloaded (or the columns are manually sorted). This will be an issue for anyone creating the charts but for those using them it should look fine.
To sort the sparklines, I'm using the last value in the sparkline chart. Open to suggestions if you think there's a better way to sort this.