Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-9795][Sort] Optimize the definition of enumeration variables and remove the semicolon #9764

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

YaziLee
Copy link
Contributor

@YaziLee YaziLee commented Mar 1, 2024

Fix #9795

Prepare a Pull Request

  • Title Example: [INLONG-9795][Sort] Optimize the definition of enumeration variables…

Motivation

The current enumeration class org.apache.inlong.sort.redis.common.config.RedisDataType is defined as,
; symbol ends. Although there is no grammatical problem with this, the code looks confusing, so it is recommended to modify it and remove it.
; symbol makes the code look clearer.

Modifications

Removed the trailing symbol "" of the enumeration class org.apache.inlong.sort.redis.common.config.RedisDataType,
;".

Verifying this change

None

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @YaziLee, thank you for submitting a PR to InLong 💖 We will respond as soon as possible ⏳
This seems to be your first PR 🌠 Please be sure to follow our Contribution Guidelines.
If you have any questions in the meantime, you can also ask us on the InLong Discussions 🔍

@dockerzhang
Copy link
Contributor

@YaziLee thanks for your contribution, please create an issue to describe the problem.

@EMsnap
Copy link
Contributor

EMsnap commented Mar 4, 2024

please change the title [INLONG-hello] to inlong-issueNumber

@YaziLee YaziLee changed the title [INLONG-hello][Sort] Optimize the definition of enumeration variables… [INLONG-9795][Sort] Optimize the definition of enumeration variables… Mar 11, 2024
@dockerzhang dockerzhang changed the title [INLONG-9795][Sort] Optimize the definition of enumeration variables… [INLONG-9795][Sort] Optimize the definition of enumeration variables and remove the semicolon Mar 11, 2024
@dockerzhang dockerzhang requested review from EMsnap and vernedeng March 11, 2024 10:38
…e enumeration definition of the Redis connector project module.
Copy link
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang merged commit 829a09b into apache:master Mar 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants