Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-9795][Sort] Regarding the format optimization of the data type definition #9796

Closed
wants to merge 1 commit into from

Conversation

YaziLee
Copy link
Contributor

@YaziLee YaziLee commented Mar 12, 2024

Prepare a Pull Request

Motivation

The current enumeration class org.apache.inlong.sort.redis.common.config.RedisDataType is defined as,
; symbol ends. Although there is no grammatical problem with this, the code looks confusing, so it is recommended to modify it and remove it.
; symbol and add ";" that makes the code look clearer.

Modifications

Removed the trailing symbol "" of the enumeration class org.apache.inlong.sort.redis.common.config.RedisDataType,
;".

Verifying this change

None

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

…e enumeration definition of the Redis connector project module.
@baomingyu
Copy link
Contributor

…e enumeration definition of the Redis connector project module.

Prepare a Pull Request

Motivation

The current enumeration class org.apache.inlong.sort.redis.common.config.RedisDataType is defined as, ; symbol ends. Although there is no grammatical problem with this, the code looks confusing, so it is recommended to modify it and remove it. ; symbol and add ";" that makes the code look clearer.

Modifications

Removed the trailing symbol "" of the enumeration class org.apache.inlong.sort.redis.common.config.RedisDataType, ;".

Verifying this change

None

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Modify title please!

@YaziLee YaziLee changed the title [INLONG-9795][Sort] Regarding the format optimization of the data typ… [INLONG-9795][Sort] Regarding the format optimization of the data type definition Mar 12, 2024
@aloyszhang
Copy link
Contributor

duplicated pull request with #9764

@aloyszhang
Copy link
Contributor

Hi @YaziLee,
I think you're trying to resolve the comment #9764 (comment).
It's better to resolve it in the original pull request(#9764 )

@aloyszhang
Copy link
Contributor

aloyszhang commented Mar 12, 2024

close this pull request first since duplciated with #9764

@aloyszhang aloyszhang closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants