KAFKA-12796: Removal of deprecated classes under streams-scala
#10710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlprat
commented
May 17, 2021
| @@ -304,7 +304,7 @@ class KTable[K, V](val inner: KTableJ[K, V]) { | |||
| new KStream(inner.toStream[KR](mapper.asKeyValueMapper, named)) | |||
|
|
|||
| /** | |||
| * Suppress some updates from this changelog stream, determined by the supplied [[Suppressed]] configuration. | |||
| * Suppress some updates from this changelog stream, determined by the supplied [[org.apache.kafka.streams.kstream.Suppressed]] configuration. | |||
There was a problem hiding this comment.
Use the right non-deprecated class
|
cc @cadonna PR is ready for review, if you would like to take a look. Thanks! |
Removes previously deprecated methods in older KIPs
jlprat
force-pushed
the
KAFKA-12796-removal-deprecated-classes-streams-scala
branch
from
b001d75 to
5dde99d
Compare
|
As discussed with @ableegoldman only classes deprecated since at least 2.5 can be removed. For this reason, |
|
Failed test is unrelated and known to be flaky: |
|
Thanks for the review @cadonna ! |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
May 27, 2021
…nups * apache-github/trunk: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout` (apache#10759) KAFKA-12796: Removal of deprecated classes under streams-scala (apache#10710) KAFKA-12819: Add assert messages to MirrorMaker tests plus other quality of life improvements (apache#10762) Update implementation.html (apache#10771) MINOR: Log constructor: Flip logical NOT for readability (apache#10756) MINOR: deprecate TaskMetadata constructor and add KIP-740 notes to upgrade guide (apache#10755) MINOR: Log more information when producer snapshot is written (apache#10757) KAFKA-12260: Avoid hitting NPE for partitionsFor (apache#10017) MINOR: add window verification to sliding-window co-group test (apache#10745) KAFKA-12800: Configure generator to fail on trailing JSON tokens (apache#10717)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes previously deprecated methods in older KIPs
Committer Checklist (excluded from commit message)