Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Log constructor: Flip logical NOT for readability #10756

Merged
merged 1 commit into from
May 26, 2021
Merged

MINOR: Log constructor: Flip logical NOT for readability #10756

merged 1 commit into from
May 26, 2021

Conversation

kowshik
Copy link
Contributor

@kowshik kowshik commented May 25, 2021 •
edited
Loading

I've done a small improvement in this PR by flipping logical NOT for readability in the Log constructor.
Basically, the following code:

if (A) {
 if (B) {
 } else {
 }
} else if (B) {
}

is a bit more readable than:

if (A) {
 if (!B) {
 } else {
 }
} else if (B) {
}

Tests:

Relying on existing tests.

@kowshik
Copy link
Contributor Author

kowshik commented May 25, 2021

cc @junrao @ijuma @chia7712 for review

junrao
junrao approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@junrao junrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kowshik : Thanks for the PR. LGTM

@junrao junrao merged commit 47094ef into apache:trunk May 26, 2021
ijuma added a commit to ijuma/kafka that referenced this pull request May 27, 2021
@ijuma
Merge remote-tracking branch 'apache-github/trunk' into topic-id-clea…
d74c08f 
…nups

* apache-github/trunk:
MINOR: Adjust parameter ordering of `waitForCondition` and
`retryOnExceptionWithTimeout` (apache#10759)
KAFKA-12796: Removal of deprecated classes under streams-scala
(apache#10710)
KAFKA-12819: Add assert messages to MirrorMaker tests plus other
quality of life improvements (apache#10762)
  Update implementation.html (apache#10771)
  MINOR: Log constructor: Flip logical NOT for readability (apache#10756)
MINOR: deprecate TaskMetadata constructor and add KIP-740 notes to
upgrade guide (apache#10755)
  MINOR: Log more information when producer snapshot is written (apache#10757)
  KAFKA-12260: Avoid hitting NPE for partitionsFor (apache#10017)
MINOR: add window verification to sliding-window co-group test
(apache#10745)
KAFKA-12800: Configure generator to fail on trailing JSON tokens
(apache#10717)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrao junrao junrao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kowshik @junrao