Automatically download the golangci-lint if not exists #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clundro <infdahai@outlook.com>
infdahai
force-pushed
the
golangci_lint
branch
2 times, most recently
from
4dee6ca to
c9a6f64
Compare
PragmaTwice
reviewed
Jun 11, 2023
Signed-off-by: clundro <infdahai@outlook.com>
Signed-off-by: clundro <infdahai@outlook.com>
PragmaTwice
reviewed
Jun 13, 2023
tisonkun
requested changes
Jun 13, 2023
Signed-off-by: clundro <infdahai@outlook.com>
git-hulk
changed the title
infdahai
commented
Jun 14, 2023
Signed-off-by: clundro <infdahai@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use
dpkgto install golanglint-ci packags in sys_path because the visit to raw.github.com for me is unstable. So I think we can support this way about system paths.If we find the package exists in system path, we will do check-version function and the program raises an error to tell users to update system packages if the check fails.
If we don't find it, we get the package from GoPATH or download it from github.
These two ways are from https://golangci-lint.run/usage/install/.