Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically download the golangci-lint if not exists #1491

Merged
merged 10 commits into from
Jul 4, 2023
Merged

Automatically download the golangci-lint if not exists #1491

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
99df6cb
get system golangci_lint
infdahai Jun 11, 2023
063075d
refactor
infdahai Jun 11, 2023
0130910
add assert for `which cmd`
infdahai Jun 11, 2023
f0f4104
remove unnecessary assert
infdahai Jun 11, 2023
8bd78ab
Merge branch 'unstable' into golangci_lint
git-hulk Jun 13, 2023
2d7ded2
split nested functions
infdahai Jun 13, 2023
38e80b3
Merge remote-tracking branch 'upstream/golangci_lint' into golangci_lint
infdahai Jun 13, 2023
bc6548b
remove the wrong type
infdahai Jun 14, 2023
8c86c4a
fix typo
infdahai Jun 14, 2023
d3ac01a
Merge branch 'unstable' into golangci_lint
tisonkun Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions x.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
CMAKE_REQUIRE_VERSION = (3, 16, 0)
CLANG_FORMAT_REQUIRED_VERSION = (12, 0, 0)
CLANG_TIDY_REQUIRED_VERSION = (12, 0, 0)
GOLANGCI_LINT_REQUIRED_VERSION = (1, 49, 0)

SEMVER_REGEX = re.compile(
r"""
Expand Down Expand Up @@ -192,15 +193,24 @@ def clang_tidy(dir: str, jobs: Optional[int], clang_tidy_path: str, run_clang_ti
run(run_command, *options, *regexes, verbose=True, cwd=basedir)


def golangci_lint() -> None:
go = find_command('go', msg='go is required for testing')
gopath = run_pipe(go, 'env', 'GOPATH').read().strip()
bindir = Path(gopath).absolute() / 'bin'
binpath = bindir / 'golangci-lint'
if not binpath.exists():
output = run_pipe('curl', '-sfL', 'https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh',
verbose=True)
run('sh', '-s', '--', '-b', str(bindir), 'v1.49.0', verbose=True, stdin=output)
def golangci_lint(golangci_lint_path: str) -> None:
binpath = ""
golangci_command = find_command(golangci_lint_path, msg="golangci-lint is required")
infdahai marked this conversation as resolved.
Show resolved Hide resolved
version_res = run_pipe(golangci_command, '--version').read().strip()
version_str = re.search(r'version\s+((?:\w|\.)+)', version_res).group(1)

if golangci_command:
check_version(version_str, GOLANGCI_LINT_REQUIRED_VERSION, "golangci-lint")
binpath = golangci_command
else:
go = find_command('go', msg='go is required for testing')
gopath = run_pipe(go, 'env', 'GOPATH').read().strip()
bindir = Path(gopath).absolute() / 'bin'
binpath = bindir / 'golangci-lint'
if not binpath.exists():
output = run_pipe('curl', '-sfL', 'https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh',
verbose=True)
run('sh', '-s', '--', '-b', str(bindir), 'v1.49.0', verbose=True, stdin=output)
basedir = Path(__file__).parent.absolute() / 'tests' / 'gocase'
run(str(binpath), 'run', '-v', './...', cwd=str(basedir), verbose=True)

Expand Down Expand Up @@ -319,7 +329,9 @@ def test_go(dir: str, cli_path: str, rest: List[str]) -> None:
formatter_class=ArgumentDefaultsHelpFormatter,
)
parser_check_golangci_lint.set_defaults(func=golangci_lint)

parser_check_golangci_lint.add_argument('--golangci-lint-path', default='golangci-lint',
help="path of golangci-lint used to check source")

parser_build = subparsers.add_parser(
'build',
description="Build executables to BUILD_DIR [default: build]",
Expand Down