Return an error when Stream::Range fails and remove some debug server logs #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enjoy-binbin
commented
Jul 6, 2023
xiaobiaozhao
force-pushed
the
remove_debug_log
branch
from
ee4dc70 to
cf80ff7
Compare
|
@xiaobiaozhao Why force push cf80ff7? |
rebase ？ |
It is very weird. DO NOT force push to other contributor's branch without notification. If you want to merge unstable to it, just click the "Update Branch" button, it will append a new commit. |
|
@xiaobiaozhao And I would like to state that I believe this is a very serious violation of the "unspoken agreement" among committers in git operations. |
|
Yes, you can append a new commit and SHOULD NOT rebase or force push to other contributors' PR. |
OK, got it |
These logs were there in the earliest days, i guess they are for debug, remove them now to avoid polluting the server logs. The blpop one is easy to reproduce: ``` Failed to execute redis command: blpop, err: Invalid argument: WRONGTYPE Operation against a key holding the wrong kind of value ``` Checked the relevant LOG calls and fix a typo.
enjoy-binbin
force-pushed
the
remove_debug_log
branch
from
cf80ff7 to
8876d60
Compare
enjoy-binbin
changed the title
|
i doing a force-push since it is a trivial diff. |
git-hulk
previously approved these changes
Jul 17, 2023
git-hulk
approved these changes
Jul 17, 2023
|
Thanks all, merging... |
git-hulk
pushed a commit
to git-hulk/kvrocks
that referenced
this pull request
Jul 30, 2023
… logs (apache#1556) This PR has two parts. The first one, internally, both XREAD and XRANGE call the Stream::Range function. When Range fails, we should return an error. The second one is to remove the debug logs. These logs were there in the earliest days, I guess they are for debugging, remove them now to avoid polluting the server logs. The blpop one is easy to reproduce: ``` Failed to execute redis command: blpop, err: Invalid argument: WRONGTYPE Operation against a key holding the wrong kind of value ```
Merged
git-hulk
pushed a commit
that referenced
this pull request
Aug 1, 2023
… logs (#1556) This PR has two parts. The first one, internally, both XREAD and XRANGE call the Stream::Range function. When Range fails, we should return an error. The second one is to remove the debug logs. These logs were there in the earliest days, I guess they are for debugging, remove them now to avoid polluting the server logs. The blpop one is easy to reproduce: ``` Failed to execute redis command: blpop, err: Invalid argument: WRONGTYPE Operation against a key holding the wrong kind of value ```
p1u3o
pushed a commit
to p1u3o/incubator-kvrocks
that referenced
this pull request
Aug 1, 2023
… logs (apache#1556) This PR has two parts. The first one, internally, both XREAD and XRANGE call the Stream::Range function. When Range fails, we should return an error. The second one is to remove the debug logs. These logs were there in the earliest days, I guess they are for debugging, remove them now to avoid polluting the server logs. The blpop one is easy to reproduce: ``` Failed to execute redis command: blpop, err: Invalid argument: WRONGTYPE Operation against a key holding the wrong kind of value ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two parts.
The first one, internally, both XREAD and XRANGE call the Stream::Range
function. When Range fails, we should return an error.
The second one is to remove the debug logs. These logs were there in the
earliest days, i guess they are for debug, remove them now to avoid polluting
the server logs.
The blpop one is easy to reproduce:
Checked the relevant LOG calls and fix a typo.