-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NbLaunchDelegate
fix and test multi line texts in suite.py
#7011
Conversation
assertEquals(fo, lkp.lookup(FileObject.class)); | ||
|
||
DataObject obj = lkp.lookup(DataObject.class); | ||
assertNotNull("DataObject also found", obj); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While writing my Enso code, I was surprised I cannot find EnsoDataObject
in the lookup. 8838cff fixes that.
NbLaunchDelegate
fix and test multi line texts in suite.py
7b0fe91
to
c27fa6f
Compare
This change is currently breaking master. Looking at the timestamps this PR was merged without waiting for CI to complete. Please check if this can be fixed. https://github.com/apache/netbeans/actions/runs/7864172928 PR run |
Ops. Sorry for the mistake.
I guess I got confused with CI & labels. Everything was green, but I probably used labels incorrectly. I'll do my best to be more careful next time. |
Thanks for merging the revert @jtulach Two things to be aware :
|
this page on the wiki is explaining a bit how the CI pipeline works: I think this PR might have been fine if CI would have finished running after the second sync. There is actually an option to enforce "green checks" before gh allows the merge. But last time when we considered to enable that, there were concerns that this could lock us out as far as I remember. (although I think there would be enough tricks left to get around that lockout and unblock it again) |
I cannot open graal/sdk project anymore. Turns out that now its suite.py is using multiline texts and the conversion of
suite.py
to JSON fails to convert that properly. This PR provides a test and a fix to handle such conversion properly. With the fix I am able to opensdk
as well astruffle
project without errors.This fix affects NetBeans IDE, VSCode extension and IGV. CCing @rschatz, @gilles-duboscq