ActionProvider & its Lookup consolidation in VSCode extension #7105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtulach
added
LSP
2 tasks
entlicher
approved these changes
Feb 26, 2024
sdedic
approved these changes
Feb 26, 2024
lahodaj
approved these changes
Feb 27, 2024
mergify bot
pushed a commit
to enso-org/enso
that referenced
this pull request
Apr 18, 2024
Turns out that #8923 isn't enough to support debugging of `Vector_Spec.enso` when root of Enso repository is opened as a folder/workspace. To allow debugging of `Vector_Spec.enso` two changes are needed. One is provided in this PR, the other one will be integrated as apache/netbeans#7105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third attempt to integrate
ActionProviderand itsLookupimprovements needed by enso-org/enso#9041. #7011 got merged with failing tests and reverted. #7059 was targeted fordeliverybranch, but that one has been deleted already.java.mx.projectsfor behavior implemented by Update the mx suite parsing to work with sources of GraalVM version 23.1.0 #7013createTargetLookupmethod and uses it forisEnabledcheck as well asinvokeAction(I believe)FileObject&DataObjectto the lookup even when working on the whole Project - that's the change which fixes problems we face in EnsoPer discussion in #7059 the
Projectinstance is included in thecreateTargetLookup, but not the content ofProject.getLookup().