Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support also COMMAND_RUN and COMMAND_DEBUG actions #9041

Merged
merged 7 commits into from
Apr 18, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Feb 13, 2024

Pull Request Description

Turns out that #8923 isn't enough to support debugging of Vector_Spec.enso when root of Enso repository is opened as a folder/workspace. To allow debugging of Vector_Spec.enso two changes are needed. One is provided in this PR, the other one will be integrated as apache/netbeans#7105

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
    style guides.
  • All code has been tested:
    • Manually tested debugging of Vector_Spec

@JaroslavTulach JaroslavTulach added CI: No changelog needed Do not require a changelog entry for this PR. --bug Type: bug labels Feb 13, 2024
@JaroslavTulach JaroslavTulach self-assigned this Feb 13, 2024
@JaroslavTulach JaroslavTulach added x-on-hold s-downstream The bug is caused by a downstream bug (a library or tooling bug) labels Feb 13, 2024
@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Feb 13, 2024

Cannot merge right now. Waiting for apache/netbeans#7059 to get in and be released.

@JaroslavTulach
Copy link
Member Author

Updating the upstream PR again: apache/netbeans#7059 (comment) and discussing next steps.

@JaroslavTulach
Copy link
Member Author

apache/netbeans#7105 has been merged. Now we are waiting for a newer release of Apache NetBeans Extension than 21.0.0. If the release gods are with us, it should be out in two months...

@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Apr 17, 2024

Version 21.9.9 is out since 13. 4. 2024, let's verify if it fixes the problem! Download VSCode Extension 1.33.440 and test it!

Open Number_Spec.enso (while having root of Enso repository opened as a workspace - without the workspace the debugging was already working even before). Put a breakpoint into the file and start debugging. You'll be asked for a location of bin/enso executable - provide one:

bin/enso

press Enter and then the execution starts. After a while the breakpoint is hit:

breakpoint hit

Great, let's release VSCode Extension 1.33.440!

@JaroslavTulach JaroslavTulach added the CI: Keep up to date Automatically update this PR to the latest develop. label Apr 17, 2024
@JaroslavTulach
Copy link
Member Author

Version 1.33.440 has been uploaded to marketplace. Thank you @ola-lis!

@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Apr 18, 2024
@mergify mergify bot merged commit c8dcd48 into develop Apr 18, 2024
38 checks passed
@mergify mergify bot deleted the wip/jtulach/DebugVectorSpec branch April 18, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug CI: Keep up to date Automatically update this PR to the latest develop. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge s-downstream The bug is caused by a downstream bug (a library or tooling bug)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants