Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No persistance for Shadowed$FunctionParam. #8896

Closed
Akirathan opened this issue Jan 30, 2024 · 2 comments · Fixed by #9024
Closed

No persistance for Shadowed$FunctionParam. #8896

Akirathan opened this issue Jan 30, 2024 · 2 comments · Fixed by #9024
Assignees
@JaroslavTulach
Labels
-compiler

Comments

@Akirathan
Copy link
Member

In project Unbooked_Seats.zip, I have a lot of these failures:

[ERROR] [2024-01-30T10:18:58+01:00] [enso.org.enso.interpreter.caches.ModuleCache] Failed to save cache for local.Unbooked_Seats.Main.
java.io.IOException: No persistance for org.enso.compiler.core.ir.expression.warnings.Shadowed$FunctionParam
	at org.enso.runtime/org.enso.persist.PerMap.searchSupertype(PerMap.java:74)
	at org.enso.runtime/org.enso.persist.PerMap.searchSupertype(PerMap.java:67)
	at org.enso.runtime/org.enso.persist.PerMap.searchSupertype(PerMap.java:67)
	at org.enso.runtime/org.enso.persist.PerMap.forType(PerMap.java:84)
	at org.enso.runtime/org.enso.persist.PerGenerator.writeIndirect(PerGenerator.java:80)
	at org.enso.runtime/org.enso.persist.PerGenerator$ReferenceOutput.writeObject(PerGenerator.java:127)
	at org.enso.runtime/org.enso.compiler.core.ir.IrPersistance$PersistScalaList.writeObject(IrPersistance.java:207)
	at org.enso.runtime/org.enso.compiler.core.ir.IrPersistance$PersistScalaList.writeObject(IrPersistance.java:195)
	at org.enso.runtime/org.enso.persist.Persistance.writeInline(Persistance.java:147)
	at org.enso.runtime/org.enso.persist.PerGenerator$ReferenceOutput.writeInline(PerGenerator.java:122)
	at org.enso.runtime/org.enso.compiler.core.ir.IrPersistance$PersistDiagnosticStorage.writeObject(IrPersistance.java:409)
	at org.enso.runtime/org.enso.compiler.core.ir.IrPersistance$PersistDiagnosticStorage.writeObject(IrPersistance.java:401)
	at org.enso.runtime/org.enso.persist.Persistance.writeInline(Persistance.java:147)
	at org.enso.runtime/org.enso.persist.PerGenerator$ReferenceOutput.writeInline(PerGenerator.java:122)
	at org.enso.runtime/org.enso.compiler.core.ir.PersistDefinitionArgument_Specified.writeObject(PersistDefinitionArgument_Specified.java:32)
	at org.enso.runtime/org.enso.compiler.core.ir.PersistDefinitionArgument_Specified.writeObject(PersistDefinitionArgument_Specified.java:4)
	at org.enso.runtime/org.enso.persist.Persistance.writeInline(Persistance.java:147)
	at org.enso.runtime/org.enso.persist.PerGenerator.writeIndirect(PerGenerator.java:88)
	at org.enso.runtime/org.enso.persist.PerGenerator$ReferenceOutput.writeObject(PerGenerator.java:127)
	at org.enso.runtime/org.enso.compiler.core.ir.IrPersistance$PersistScalaList.writeObject(IrPersistance.java:207)
	at org.enso.runtime/org.enso.compiler.core.ir.IrPersistance$PersistScalaList.writeObject(IrPersistance.java:195)
	at org.enso.runtime/org.enso.persist.Persistance.writeInline(Persistance.java:147)
	at org.enso.runtime/org.enso.persist.PerGenerator$ReferenceOutput.writeInline(PerGenerator.java:122)
	at org.enso.runtime/org.enso.compiler.core.ir.PersistFunction_Lambda.writeObject(PersistFunction_Lambda.java:25)
	at org.enso.runtime/org.enso.compiler.core.ir.PersistFunction_Lambda.writeObject(PersistFunction_Lambda.java:4)
	at org.enso.runtime/org.enso.persist.Persistance.writeInline(Persistance.java:147)
	at org.enso.runtime/org.enso.persist.PerGenerator.writeIndirect(PerGenerator.java:88)
	at org.enso.runtime/org.enso.persist.PerGenerator$ReferenceOutput.writeObject(PerGenerator.java:127)
	at org.enso.runtime/org.enso.compiler.core.ir.IrPersistance$PersistScalaSeq.writeObject(IrPersistance.java:358)
	at org.enso.runtime/org.enso.compiler.core.ir.IrPersistance$PersistScalaSeq.writeObject(IrPersistance.java:347)
	at org.enso.runtime/org.enso.persist.Persistance.writeInline(Persistance.java:147)
	at org.enso.runtime/org.enso.persist.PerGenerator$ReferenceOutput.writeInline(PerGenerator.java:122)
	at org.enso.runtime/org.enso.compiler.core.ir.PersistMethod_Explicit.writeObject(PersistMethod_Explicit.java:27)
	at org.enso.runtime/org.enso.compiler.core.ir.PersistMethod_Explicit.writeObject(PersistMethod_Explicit.java:4)
	at org.enso.runtime/org.enso.persist.Persistance.writeInline(Persistance.java:147)
	at org.enso.runtime/org.enso.persist.PerGenerator.writeIndirect(PerGenerator.java:88)
	at org.enso.runtime/org.enso.persist.PerGenerator$ReferenceOutput.writeObject(PerGenerator.java:127)
	at org.enso.runtime/org.enso.compiler.core.ir.IrPersistance$PersistScalaList.writeObject(IrPersistance.java:207)
	at org.enso.runtime/org.enso.compiler.core.ir.IrPersistance$PersistScalaList.writeObject(IrPersistance.java:195)
	at org.enso.runtime/org.enso.persist.Persistance.writeInline(Persistance.java:147)
	at org.enso.runtime/org.enso.persist.PerGenerator$ReferenceOutput.writeInline(PerGenerator.java:122)
	at org.enso.runtime/org.enso.compiler.core.ir.PersistModule.writeObject(PersistModule.java:28)
	at org.enso.runtime/org.enso.compiler.core.ir.PersistModule.writeObject(PersistModule.java:4)
	at org.enso.runtime/org.enso.persist.Persistance.writeInline(Persistance.java:147)
	at org.enso.runtime/org.enso.persist.PerGenerator.writeObject(PerGenerator.java:64)
	at org.enso.runtime/org.enso.persist.PerGenerator.writeObject(PerGenerator.java:42)
	at org.enso.runtime/org.enso.persist.Persistance.write(Persistance.java:186)
	at org.enso.runtime/org.enso.interpreter.caches.ModuleCache.serialize(ModuleCache.java:152)
	at org.enso.runtime/org.enso.interpreter.caches.ModuleCache.serialize(ModuleCache.java:25)
	at org.enso.runtime/org.enso.interpreter.caches.Cache.saveCacheTo(Cache.java:126)
	at org.enso.runtime/org.enso.interpreter.caches.Cache.lambda$save$0(Cache.java:88)
	at java.base/java.util.Optional.flatMap(Optional.java:289)
	at org.enso.runtime/org.enso.interpreter.caches.Cache.save(Cache.java:84)
	at org.enso.runtime/org.enso.interpreter.runtime.TruffleCompilerContext.saveCache(TruffleCompilerContext.java:184)
	at org.enso.runtime/org.enso.interpreter.runtime.SerializationManager.$anonfun$doSerializeModule$1(SerializationManager.scala:611)
	at org.enso.runtime/org.enso.interpreter.runtime.SerializationManager.$anonfun$doSerializeModule$1$adapted(SerializationManager.scala:591)
	at org.enso.runtime/org.enso.interpreter.runtime.SerializationManager.serializeModule(SerializationManager.scala:138)
	at org.enso.runtime/org.enso.interpreter.instrument.job.SerializeModuleJob.lambda$run$0(SerializeModuleJob.java:44)
	at java.base/java.util.Optional.ifPresent(Optional.java:178)
	at org.enso.runtime/org.enso.interpreter.instrument.job.SerializeModuleJob.run(SerializeModuleJob.java:32)
	at org.enso.runtime/org.enso.interpreter.instrument.job.SerializeModuleJob.run(SerializeModuleJob.java:10)
	at org.enso.runtime/org.enso.interpreter.instrument.execution.JobExecutionEngine.$anonfun$runInternal$1(JobExecutionEngine.scala:124)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotThread.access$001(PolyglotThread.java:53)
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotThread$1.execute(PolyglotThread.java:106)
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotThread$ThreadSpawnRootNode.executeImpl(PolyglotThread.java:140)
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotThread$ThreadSpawnRootNode.execute(PolyglotThread.java:131)
	at org.graalvm.truffle.runtime/com.oracle.truffle.runtime.OptimizedCallTarget.executeRootNode(OptimizedCallTarget.java:746)
	at org.graalvm.truffle.runtime/com.oracle.truffle.runtime.OptimizedCallTarget.profiledPERoot(OptimizedCallTarget.java:669)
	at org.graalvm.truffle.runtime/com.oracle.truffle.runtime.OptimizedCallTarget.callBoundary(OptimizedCallTarget.java:602)
	at org.graalvm.truffle.runtime/com.oracle.truffle.runtime.OptimizedCallTarget.doInvoke(OptimizedCallTarget.java:586)
	at org.graalvm.truffle.runtime/com.oracle.truffle.runtime.OptimizedCallTarget.callIndirect(OptimizedCallTarget.java:519)
	at org.graalvm.truffle.runtime/com.oracle.truffle.runtime.OptimizedCallTarget.call(OptimizedCallTarget.java:500)
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotThread.run(PolyglotThread.java:102)

Full log attached in
enso-project-manager-2024-01-30.0.log
@JaroslavTulach JaroslavTulach moved this from ❓New to 📤 Backlog in Issues Board Jan 30, 2024
@JaroslavTulach
Copy link
Member

There was a discussion once about persisting errors. We certainly don't want to persist files with errors. I am not completely sure, but we probably don't want to persist even files with warnings. As such the failure reported by this issue may be accurate - maybe it's just too verbosely logged (but it is not easy to differentiate between IR with/without errors/warnings).

@JaroslavTulach JaroslavTulach mentioned this issue Feb 12, 2024
Merged
2 tasks
@JaroslavTulach JaroslavTulach moved this from 📤 Backlog to 👁️ Code review in Issues Board Feb 12, 2024
@enso-bot enso-bot bot mentioned this issue Feb 13, 2024
Closed
@mergify mergify bot closed this as completed in #9024 Feb 13, 2024
mergify bot pushed a commit that referenced this issue Feb 13, 2024
@JaroslavTulach
Don't print stacktraces of IOException (#9024)
04161b3 
Fixes #8896 by logging `IOException` only with `WARNING` and not `SEVERE`. As such the stacktrace of the exception isn't included in the console and failures to store cache are reported as simple messages, not exceptions with stack trace.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Feb 13, 2024
@enso-bot
Copy link

enso-bot bot commented Feb 14, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-02-13):

Progress: - Closed #8896 as completed via #9024.

Next Day: Autoscoping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaroslavTulach JaroslavTulach

Labels
-compiler
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't print stacktraces of IOException enso-org/enso
2 participants
@Akirathan @JaroslavTulach