Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-12491 Added Starting Row Schema Strategy to ExcelReader for 1.x branch #9081

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Jul 15, 2024

Summary

NIFI-12491

This feature has been added for the 2.x branch with #9064. This PR is to have it added to the 1.x branch. Per the comments in NIFI-11167 and NIFI-13304 it would seem this feature along with SplitExcel processor will help customers who had used ConvertExcelToCSV in 1.x be able to make a smoother transition from 1.x to 2.x.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21 8

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@dan-s1 dan-s1 changed the title NIFI-12491 Added Starting Row Schema Strategy to ExcelReader NIFI-12491 Added Starting Row Schema Strategy to ExcelReader for 1.x branch Jul 15, 2024
@dan-s1 dan-s1 requested a review from exceptionfactory July 15, 2024 16:38
@dan-s1
Copy link
Contributor Author

dan-s1 commented Jul 15, 2024

@exceptionfactory I cannot seem to restart the MacOs build (as the current failure has nothing to do with my changes). I do not see an icon on the side of the build on this page nor on this page which would allow me to restart. Please advise. Thanks!

@dan-s1
Copy link
Contributor Author

dan-s1 commented Jul 15, 2024

@exceptionfactory I noticed I was able to restart (i.e. the icon was available) after all the jobs were done. If you changed something thank you!

@dan-s1
Copy link
Contributor Author

dan-s1 commented Jul 15, 2024

@exceptionfactory
The MacOS build seems to consistently fail on the test below which I do not think has anything to do with my changes. I have already run this build three times. Please advise.

Error:  Tests run: 17, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 25.52 s <<< FAILURE! -- in org.apache.nifi.processors.standard.TestListFile
Error:  org.apache.nifi.processors.standard.TestListFile.testFilterAge -- Time elapsed: 6.549 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <age2.txt> but was: <age1.txt>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
	at org.apache.nifi.processors.standard.TestListFile.testFilterAge(TestListFile.java:330)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at java.util.ArrayList.forEach(ArrayList.java:1259)
	at java.util.ArrayList.forEach(ArrayList.java:1259)

@exceptionfactory
Copy link
Contributor

@exceptionfactory The MacOS build seems to consistently fail on the test below which I do not think has anything to do with my changes. I have already run this build three times. Please advise.

Error:  Tests run: 17, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 25.52 s <<< FAILURE! -- in org.apache.nifi.processors.standard.TestListFile
Error:  org.apache.nifi.processors.standard.TestListFile.testFilterAge -- Time elapsed: 6.549 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <age2.txt> but was: <age1.txt>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
	at org.apache.nifi.processors.standard.TestListFile.testFilterAge(TestListFile.java:330)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at java.util.ArrayList.forEach(ArrayList.java:1259)
	at java.util.ArrayList.forEach(ArrayList.java:1259)

This is an unstable test, which we adjusted on the main branch, so not a concern for this pull request.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting this improvement @dan-s1! +1 merging

@exceptionfactory exceptionfactory merged commit 2195956 into apache:support/nifi-1.x Jul 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants