Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Allow builds to pass even if final artifact upload fails #2592

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

btashton
Copy link
Contributor

Summary

We are seeing higher cases of artifact upload failures
in github. Other projects are also seeing this as has been
reported at actions/upload-artifact#116

There is a fix that was just merged in the base library:
actions/toolkit#675

So Hopefully we can revert this before too long.

Signed-off-by: Brennan Ashton bashton@brennanashton.com

Impact

Final build artifacts might not be uploaded, but this will not cause a build to fail. I am using these build artifacts for analysis and testing so I would like to keep them enabled if possible.

We are seeing higher cases of artifact upload failures
in github.  Other projects are also seeing this as has been
reported at actions/upload-artifact#116

There is a fix that was just merged in the base library:
actions/toolkit#675

So Hopefully we can revert this before too long.

Signed-off-by: Brennan Ashton <bashton@brennanashton.com>
@jerpelea jerpelea self-requested a review December 23, 2020 07:46
@Ouss4 Ouss4 merged commit 570aa3c into master Dec 23, 2020
@Ouss4 Ouss4 deleted the art-failure branch December 23, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants