Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-FORMAT-3: Enable Protocol Buffers Linter #4

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Dec 8, 2023

What changes were proposed in this pull request?

This close #3 .

Note that INFRA-25254 is required to allow bufbuild GitHub Action.

Why are the changes needed?

To normalize ORC Format ProtocolBuffers file easily.

How was this patch tested?

Manual review.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Dec 8, 2023

I filed INFRA-25254 to allow bufbuild GitHub Action plugin.

@dongjoon-hyun dongjoon-hyun added this to the 1.0.0 milestone Dec 8, 2023
@dongjoon-hyun dongjoon-hyun reopened this Dec 8, 2023
@dongjoon-hyun
Copy link
Member Author

ASF Infra team handled it.

@dongjoon-hyun dongjoon-hyun merged commit 49daab0 into apache:main Dec 8, 2023
3 checks passed
@dongjoon-hyun dongjoon-hyun deleted the ORC-FORMAT-3 branch December 8, 2023 05:47
dongjoon-hyun added a commit to apache/orc that referenced this pull request Dec 9, 2023
### What changes were proposed in this pull request?

This PR aims to use `orc-format` `1.0.0-beta`.

### Why are the changes needed?

`1.0.0-beta` has the following changes.
- apache/orc-format#5
- apache/orc-format#4
- apache/orc-format#7
- apache/orc-format#9

### How was this patch tested?

Pass the CIs.

Closes #1688 from dongjoon-hyun/ORC-1551.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
cxzl25 pushed a commit to cxzl25/orc that referenced this pull request Jan 11, 2024
### What changes were proposed in this pull request?

This PR aims to use `orc-format` `1.0.0-beta`.

### Why are the changes needed?

`1.0.0-beta` has the following changes.
- apache/orc-format#5
- apache/orc-format#4
- apache/orc-format#7
- apache/orc-format#9

### How was this patch tested?

Pass the CIs.

Closes apache#1688 from dongjoon-hyun/ORC-1551.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Protocol Buffers Linter
1 participant