ORC-1551: Use orc-format 1.0.0-beta
#1688
Conversation
dongjoon-hyun
changed the title
orc-format 1.0.0-beta
dongjoon-hyun
changed the title
orc-format 1.0.0-betaorc-format 1.0.0-beta
dongjoon-hyun
force-pushed
the
ORC-1551
branch
2 times, most recently
from
5f38535
to
f6d48dd
Compare
dongjoon-hyun
force-pushed
the
ORC-1551
branch
from
f6d48dd
to
f191fa8
Compare
|
cc @williamhyun , @wgtmac , @guiyanakuang, @stiga-huang , @coderex2522 , @deshanxiao |
| assertTrue(m.contains("Postscript: footerLength: 19 compression: NONE " + | ||
| "compressionBlockSize: 65536 version: 19 version: 99 metadataLength: 0 " + | ||
| "writerVersion: 1")); | ||
| assertTrue(m.contains("Postscript: footer_length: 19 compression: NONE " + |
There was a problem hiding this comment.
I assume this file should not be affected.
There was a problem hiding this comment.
Ya, the error message contains the protobuf field names.
|
Thank you, @wgtmac and @guiyanakuang . To start and maintain As we know, The new C++ API and dump meta data follows an official ProtocolBuffers recommendation. So, I believe we can help and persuade the down-streams like Apache Arrow easily without many blockers. |
|
Let me merge this~ |
### What changes were proposed in this pull request? This PR aims to use `orc-format` `1.0.0-beta`. ### Why are the changes needed? `1.0.0-beta` has the following changes. - apache/orc-format#5 - apache/orc-format#4 - apache/orc-format#7 - apache/orc-format#9 ### How was this patch tested? Pass the CIs. Closes apache#1688 from dongjoon-hyun/ORC-1551. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
What changes were proposed in this pull request?
This PR aims to use
orc-format1.0.0-beta.Why are the changes needed?
1.0.0-betahas the following changes.BASICrule orc-format#5Protocol BuffersLinter orc-format#4CompressionKind.BROTLIorc-format#7maven-enforcer-pluginto enforce Java and Maven versions orc-format#9How was this patch tested?
Pass the CIs.