ORC-1486: Fixes checkstyle violation in test classes for orc-core module

[dongjoon-hyun]

What changes were proposed in this pull request?

This PR fixes checkstyle violation in test sources in orc-core module.

Indentation rule is suppressed in some files explicitly.

Why are the changes needed?

The change shall ensure our test code adhere's to same formatting as our source

How was this patch tested?

Remove the following and run Checkstyle on core module.

orc/java/checkstyle-suppressions.xml

Lines 31 to 36 in 7787669

	<suppress checks="Indentation" files="src/test/*"/>
	<suppress checks="RedundantModifier" files="src/test/*"/>
	<suppress checks="ModifierOrder" files="src/test/*"/>
	<suppress checks="UpperEll" files="src/test/*"/>
	<suppress checks="NeedBraces" files="src/test/*"/>
	<suppress checks="RegexpSingleline" files="src/test/*"/>

$ cd java

$ git diff
diff --git a/java/checkstyle-suppressions.xml b/java/checkstyle-suppressions.xml
index 32e04a588..0256e3b77 100644
--- a/java/checkstyle-suppressions.xml
+++ b/java/checkstyle-suppressions.xml
@@ -44,10 +44,4 @@
   <suppress checks="CustomImportOrder" files="src/test/*"/>

   <!-- Remove the following rule when the test code clean up is completed. -->
-  <suppress checks="Indentation" files="src/test/*"/>
-  <suppress checks="RedundantModifier" files="src/test/*"/>
-  <suppress checks="ModifierOrder" files="src/test/*"/>
-  <suppress checks="UpperEll" files="src/test/*"/>
-  <suppress checks="NeedBraces" files="src/test/*"/>
-  <suppress checks="RegexpSingleline" files="src/test/*"/>
 </suppressions>

$ mvn checkstyle:check --pl core
Running `/Users/dongjoon/APACHE/orc-merge/java/mvnw`...
Using `mvn` from path: /opt/homebrew/bin/mvn
[INFO] Scanning for projects...
[INFO]
[INFO] ----------------------< org.apache.orc:orc-core >-----------------------
[INFO] Building ORC Core 2.0.0-SNAPSHOT
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- checkstyle:3.3.0:check (default-cli) @ orc-core ---
[INFO] You have 0 Checkstyle violations.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  4.228 s
[INFO] Finished at: 2023-08-25T22:13:02-07:00
[INFO] ------------------------------------------------------------------------

This closes #1590

[dongjoon-hyun]

cc @mystic-lama

[dongjoon-hyun]

I hope we can proceed in this way module by module, @mystic-lama .

[paliwalashish]

@dongjoon-hyun Thank you so much. I only get time during weekend or evening to work on OSS. Sadly got pulled into work, which took that time. I shall try to close things faster. Let me catch up with things and we can get this done ASAP

[paliwalashish]

Shall we have this block like this? I find it more easy on my eyes. We don't have to fix these things now. I can take care of this later

long[] inp = new long[]{4513343538618202719L, 4513343538618202711L,
                        2911390882471569739L, -9181829309989854913L};                                                                               

[dongjoon-hyun]

May I asked which rule complains about that, @mystic-lama ?

As you see, this PR aims to introduce the minimal changes which means to touch only Checkstyle really complains. The verification is described in the PR description, too.

To simply put, if we mix different themes arbitrarily like that, it tends to make a mistake because of the human error factor. It makes reviewers difficulty to review the PRs. It ends up as a situation we cannot merge it.

Of course, we can take care of it later independently.

[paliwalashish]

I agree with your point. I don't recall the rule, and did not mean to fix it in this PR
This is more for future, when we make code changes. I shall keep an eye for this and next time it hits, may be we can refine the rule.

[paliwalashish]

+1 LGTM

Thanks a lot @dongjoon-hyun

[dongjoon-hyun]

BTW, please note that Apache ORC has 3 year maintenance policy. It means ORC committers need to maintain branch-1.9 and branch-1.8 and branch-1.7 for three years and usually it requires us to backport from main to branch-1.9 to branch-1.8 and branch-1.7 sequentially if needed. So, we are unable to accept a drastic change like your previous PR even for one time activity. It will tease us for 3 years.

[dongjoon-hyun]

Merged to main for Apache ORC 2.0.

$ git log -n1 | tail -n2
    Authored-by: mystic-lama <mysticlama000@gmail.com>
    Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>

[dongjoon-hyun]

Let me make a PR for the rest of module. It seems that we can close this checkstyle task today.

[dongjoon-hyun]

Here is the PR.
#1601

[paliwalashish]

BTW, please note that Apache ORC has 3 year maintenance policy. It means ORC committers need to maintain branch-1.9 and branch-1.8 and branch-1.7 for three years and usually it requires us to backport from main to branch-1.9 to branch-1.8 and branch-1.7 sequentially if needed. So, we are unable to accept a drastic change like your previous PR even for one time activity. It will tease us for 3 years.

@dongjoon-hyun This is good to know.