Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1492: Fix checkstyle violations for tests in mapreduce/tools/bench modules #1601

Closed
wants to merge 2 commits into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Aug 27, 2023

What changes were proposed in this pull request?

This PR aims to fix checkstyle in mapreduce/tools/bench modules modules and removes the following.

<!-- Remove the following rule when the test code clean up is completed. -->
<suppress checks="Indentation" files="src/test/*"/>
<suppress checks="RedundantModifier" files="src/test/*"/>
<suppress checks="ModifierOrder" files="src/test/*"/>
<suppress checks="UpperEll" files="src/test/*"/>
<suppress checks="NeedBraces" files="src/test/*"/>
<suppress checks="RegexpSingleline" files="src/test/*"/>

Please note that we suppress Indentation rule on the following three files additionally.

<suppress checks="Indentation" files="src/test/org/apache/orc/mapred/TestOrcFileEvolution.java"/>
<suppress checks="Indentation" files="src/test/org/apache/orc/tools/json/TestJsonSchemaFinder.java"/>
<suppress checks="Indentation" files="src/test/org/apache/orc/tools/convert/TestJsonReader.java"/>

Why are the changes needed?

To apply Checkstyle on test codes.

How was this patch tested?

Pass the Cis. Since we removed the global suppression rules on test code, CI should verify the result.

@dongjoon-hyun dongjoon-hyun added this to the 2.0.0 milestone Aug 27, 2023
@dongjoon-hyun
Copy link
Member Author

To reviewers,

  • I made this PR, ORC-1492, as a subtask of the umbrella JIRA, ORC-1485.
  • After merging this PR, the subtask JIRA (ORC-1492) is going to be assigned to me and the umbrella JIRA (ORC-1485) is going to be assigned to @mystic-lama as a recognition of initiating and leading this activity.

@dongjoon-hyun
Copy link
Member Author

Merged to main for Apache ORC 2.0.0.

@dongjoon-hyun dongjoon-hyun deleted the ORC-1492 branch August 27, 2023 10:12
cxzl25 pushed a commit to cxzl25/orc that referenced this pull request Jan 11, 2024
…ch` modules

### What changes were proposed in this pull request?

This PR aims to fix checkstyle in `mapreduce/tools/bench modules` modules and removes the following.

https://github.com/apache/orc/blob/e4b833809b6bd6eee316232e0e96d24bd7d4f6ee/java/checkstyle-suppressions.xml#L46-L52

Please note that we suppress `Indentation` rule on the following three files additionally.

```xml
<suppress checks="Indentation" files="src/test/org/apache/orc/mapred/TestOrcFileEvolution.java"/>
<suppress checks="Indentation" files="src/test/org/apache/orc/tools/json/TestJsonSchemaFinder.java"/>
<suppress checks="Indentation" files="src/test/org/apache/orc/tools/convert/TestJsonReader.java"/>
```

### Why are the changes needed?

To apply Checkstyle on test codes.

### How was this patch tested?

Pass the Cis. Since we removed the global suppression rules on `test` code, CI should verify the result.

Closes apache#1601 from dongjoon-hyun/ORC-1492.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant