HDDS-11226. Make ExponentialBackoffPolicy maxRetries configurable #6985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivandika3
approved these changes
Jul 25, 2024
kerneltime
reviewed
Jul 25, 2024
| @@ -203,6 +203,21 @@ public void setExponentialPolicyMaxSleep(Duration duration) { | |||
| exponentialPolicyMaxSleep = duration; | |||
| } | |||
|
|
|||
| @Config(key = "client.exponential.backoff.max.retries", | |||
| defaultValue = "2147483647", | |||
There was a problem hiding this comment.
Suggested change
| defaultValue = "2147483647", | |
| defaultValue = String.valueOf(Integer.MAX_VALUE), |
There was a problem hiding this comment.
String.valueOf doesn't return constant but defaultValue requires a constant String.
Other way we can change like "" + Integer.MAX_VALUE but this has overhead of StringBuilder.
There was a problem hiding this comment.
You could define
private final static string intMax = Integer.toString(Integer.MAX_VALUE);
in this class and then assign defaultValue = intMax?
There was a problem hiding this comment.
I tried this before. Tried again, but it doesn't work. Same error "Attribute value must be constant".
adoroszlai
changed the title
smengcl
reviewed
Aug 2, 2024
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ratis/conf/RatisClientConfig.java
Outdated
Show resolved
Hide resolved
smengcl
approved these changes
Aug 2, 2024
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Aug 7, 2024
* master: (181 commits) HDDS-11289. Bump docker-maven-plugin to 0.45.0 (apache#7024) HDDS-11287. Code cleanup in XceiverClientSpi (apache#7043) HDDS-11283. Refactor KeyValueStreamDataChannel to avoid spurious IDE build issues (apache#7040) HDDS-11257. Ozone write does not work when http proxy is set for the JVM. (apache#7036) HDDS-11249. Bump ozone-runner to 20240729-jdk17-1 (apache#7003) HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info (apache#6724) HDDS-11270. [hsync] Add DN layout version (HBASE_SUPPORT/version 8) upgrade test. (apache#7021) HDDS-11272. Statistics some node status information (apache#7025) HDDS-11278. Move code out of Hadoop util package (apache#7028) HDDS-11274. (addendum) Replace Hadoop annotations/configs with Ozone-specific ones HDDS-11274. Replace Hadoop annotations/configs with Ozone-specific ones (apache#7026) HDDS-11280. Add Synchronize in AbstractCommitWatcher.addAckDataLength (apache#7032) HDDS-11235. Spare InfoBucket RPC call in FileSystem#mkdir() call. (apache#6990) HDDS-11273. Bump commons-compress to 1.26.2 (apache#7023) HDDS-11225. Increase ipc.server.read.threadpool.size (apache#7007) HDDS-11224. Increase hdds.datanode.handler.count (apache#7011) HDDS-11259. [hsync] DataNode should verify HBASE_SUPPORT layout version for every PutBlock. (apache#7012) HDDS-11214. Added config to set rocksDB's max log file size and num of log files (apache#7014) HDDS-11226. Make ExponentialBackoffPolicy maxRetries configurable (apache#6985) HDDS-11260. [hsync] Add Ozone Manager protocol version (apache#7015) ... Conflicts: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/audit/DNAction.java hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/TestContainerReportHandler.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Default max retries count is very high for ExponentialBackoffPolicy which in some cases leads to longer wait for client. Client like HBase by default timesout after 5 minutes which leads to unexpected crash.
In this PR making retry count as configurable so that after max retry client can try on different DN and doesn't need to wait for long.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11226
How was this patch tested?
Updated existing test