Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the pulsar version that unit tests depend on to 2.11.0 #969

Closed
wants to merge 1 commit into from

Conversation

shibd
Copy link
Member

@shibd shibd commented Feb 28, 2023

Motivation

Pulsar 2.11.0 has been released. Upgrade the versions that unit tests depend on so that they are compatible with the latest versions and support new features.

Modifications

  • Upgrade the pulsar version that unit tests depend on to 2.11.0.
  • The GetTopicsOfNamespace method filters system topics. (This is the break change for broker v2.11.0, which has started an email discussion. Temporarily fix it on the client side first)
  • Fix incorrect HTTP requests. (Because in v2.11.0 will validate bad requests)
  • Remove key_shared subscribe consumer unit test-related assert(that every consumer will receive the message), Because consistent hashing is enabled by default in v2.11.0, in scenarios where the number of keys is small, all messages may be sent to the same consumer.

Verifying this change

  • All tests passed.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (upgrade)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not remove the Key_Shared subscription related tests. They are used to protect the case when subscriptionKeySharedUseConsistentHashing is false.

See #970 and apache/pulsar#13963

@shibd
Copy link
Member Author

shibd commented Feb 28, 2023

I think we should not remove the Key_Shared subscription related tests. They are used to protect the case when subscriptionKeySharedUseConsistentHashing is false.

See #970 and apache/pulsar#13963

Agree, In fact, it was introduced by #953

@shibd shibd marked this pull request as draft February 28, 2023 14:22
@shibd
Copy link
Member Author

shibd commented Feb 28, 2023

wait v2.11.1 release of pulsar

@shibd shibd closed this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants