Fix flaky Key_Shared subscription related tests #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation After apache#953, the Pulsar version was upgraded from 2.8.3 to 2.10.3. However, [PIP-119](apache/pulsar#13352) changed the default value of `subscriptionKeySharedUseConsistentHashing` to true, which leads to the flakiness of Key_Shared subscription related tests. Example: https://github.com/apache/pulsar-client-go/actions/runs/4291098473/jobs/7475868787 ### Modifications Configure `subscriptionKeySharedUseConsistentHashing` with `false`.
eolivelli
approved these changes
Feb 28, 2023
RobertIndie
approved these changes
Feb 28, 2023
|
It looks like |
|
The flaky |
|
Another flaky test: #971 |
shibd
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After #953, the Pulsar version was upgraded from 2.8.3 to 2.10.3. However, PIP-119 changed the default value of
subscriptionKeySharedUseConsistentHashingto true, which leads to the flakiness of Key_Shared subscription related tests.Example: https://github.com/apache/pulsar-client-go/actions/runs/4291098473/jobs/7475868787
Modifications
Configure
subscriptionKeySharedUseConsistentHashingwithfalse.