[feat][doc] PIP-264: Add replication metrics reference #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
dragosvictor
force-pushed
the
dmisca-pip-264-replication-metrics
branch
from
9ad2f04
to
bd038c6
Compare
15 tasks
heesung-sn
reviewed
Jun 25, 2024
| * `pulsar.replication.remote.cluster.name` - The name of the remote cluster. | ||
|
|
||
| #### pulsar.broker.replication.message.backlog.count | ||
| The total number of messages in the backlog for this replicator. |
There was a problem hiding this comment.
Can we clarify a little more here? something like
The total number of messages in the backlog for this replicator has not been consumed.
heesung-sn
reviewed
Jun 25, 2024
| * `pulsar.replication.remote.cluster.name` - The name of the remote cluster. | ||
|
|
||
| #### pulsar.broker.replication.message.expired.count | ||
| The total number of messages that expired for this replicator. |
There was a problem hiding this comment.
Can we clarify a little more here? something like
The total number of messages that expired for this replicator before consuming.
| The total number of messages received from the remote cluster through this replicator. | ||
| * Type: Counter | ||
| * Unit: `{message}` | ||
| * Attributes: |
There was a problem hiding this comment.
seems like these attributes are copied multiple times. can we link a ref, instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Contribution Checklist