-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][broker] PIP-264: Add OpenTelemetry broker replicator metrics #22972
[feat][broker] PIP-264: Add OpenTelemetry broker replicator metrics #22972
Conversation
@dragosvictor is this change intended also for 3.3.x ? Do you see any reasons why we shouldn't cherry-pick this to branch-3.3 ? The reason why I'm asking is that #23236 would apply cleanly if we first cherry-pick this PR. /cc @BewareMyPower @RobertIndie |
It's not intended for 3.3, but it won't hurt either. No problem cherry-picking it. |
Checked again and perhaps minimizing the risk is worthwhile if it's not needed in 3.3.x. It's not a big deal to backport #23236 to branch-3.3. |
PIP-264
Motivation
Adds existing broker replicator metrics (documented by https://pulsar.apache.org/docs/next/reference-metrics/#replication-metrics-1) to the OpenTelemetry pipeline.
Modifications
Replicator#getStats
toReplicator#computeStats
, as it modifies the underlying object in the process. Added a simple getterReplicator#getStats
for the object itself. This helps clarify the intent of the methods.Verifying this change
This change added tests and can be verified as follows:
ReplicatorTest#testReplicationMetrics
ReplicatorTest#testResumptionAfterBacklogRelaxed
Does this pull request potentially affect one of the following parts:
Documentation
doc
doc-required
[feat][doc] PIP-264: Add replication metrics reference pulsar-site#926doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: dragosvictor#26