-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Add test to verify authRole cannot change #19430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @michaeljmarshall
Codecov Report
@@ Coverage Diff @@
## master #19430 +/- ##
============================================
+ Coverage 62.63% 62.66% +0.02%
- Complexity 25752 25768 +16
============================================
Files 1832 1832
Lines 134053 134067 +14
Branches 14752 14753 +1
============================================
+ Hits 83967 84014 +47
+ Misses 42346 42340 -6
+ Partials 7740 7713 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I cherry picked this test because it is valid for all release branches and it ensured correctness for some of my cherry picked changes, which is very valuable. |
…pache#19430)" This reverts commit 0231ad3.
…pache#19430)" This reverts commit 3e90bc2.
Motivation
While working on #19409, I noticed we do not have any tests in the
ServerCnxTests
class verifying theauthRole
cannot change. This seems like an oversight, and this PR adds tests to assert the existing behavior works as intended.Modifications
AuthenticationProvider
andAuthenticationState
implementations to simplify testingauthRole
changes.Verifying this change
This change is to add tests.
Documentation
doc-not-needed
Matching PR in forked repository
PR in forked repository: Skipping testing in my fork since these are new tests and I got them to pass locally.