-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Branch-2.10] Revert [improve][broker] Require authRole is proxyRole to set originalPrincipal(#19455) #19824
[Branch-2.10] Revert [improve][broker] Require authRole is proxyRole to set originalPrincipal(#19455) #19824
Conversation
…originalRole (apache#19557)" This reverts commit 4da2487.
…erts (apache#19594)" This reverts commit 14152fc.
…st impl" This reverts commit 09f00ee.
This reverts commit 1935f07.
…pache#19430)" This reverts commit 0231ad3.
This reverts commit 557b72d.
…ls (apache#19312)" This reverts commit 467cd32.
…alPrincipal (apache#19455)" This reverts commit 6a599af.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, this is the wrong thing to change and should not all be reverted regardless of the PMC's decision.
Second, we need consensus on the private mailing list before we merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @michaeljmarshall
We have an acceptable solution for now. So that we don't need to revert this change, just push a fix to the release branches. And @michaeljmarshall message me in Slack, he will open PR to fix it. Thanks @hangc0276 and @michaeljmarshall |
@hangc0276, in my view, #19830 should supersede this PR once it is merged and cherry picked to 2.10. Is there a reason you proposed reverting so many other changes? Thanks. |
I don't think we should revert any of the other commits--I intentionally cherry picked each for a reason. With #19830 merged and cherry picked, the original intention of this PR is fulfilled. Please reopen if I missed something @hangc0276. |
Motivation
PR #19455 introduced break change and has been cherry-picked to release branch-2.10. It will lead to users upgrading to the new release version authenticate failed. We need to revert all the related PRs.
Modifications
Revert "[fix][broker] Allow proxy to pass same role for authRole and originalRole ([fix][broker] Allow proxy to pass same role for authRole and originalRole #19557)"
This reverts commit 4da2487.
Revert "[fix][broker] Make authentication refresh threadsafe ([fix][broker] Make authentication refresh threadsafe #19506)"
This reverts commit 26e1053.
Revert "[fix][test] ProxyWithAuthorizationTest remove SAN from test certs ([fix][test] ProxyWithAuthorizationTest remove SAN from test certs #19594)"
This reverts commit 14152fc.
Revert "[fix][broker] Correct MockAlwaysExpiredAuthenticationState test impl"
This reverts commit 09f00ee.
Revert "[fix][broker] Call originalAuthState.authenticate in ServerCnx"
This reverts commit 1935f07.
Revert "[improve][broker] Add test to verify authRole cannot change ([improve][broker] Add test to verify authRole cannot change #19430)"
This reverts commit 0231ad3.
Revert "[feat][broker] Cherry-pick tests from ([feat][broker] PIP 97: Implement for ServerCnx #19409)"
This reverts commit 557b72d.
Revert "[improve][broker] ServerCnx: go to Failed state when auth fails ([improve][broker] ServerCnx: go to Failed state when auth fails #19312)"
This reverts commit 467cd32.
Revert "[improve][broker] Require authRole is proxyRole to set originalPrincipal ([improve][broker] Require authRole is proxyRole to set originalPrincipal #19455)"
This reverts commit 6a599af.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: