-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][meta] Bump jetcd to 0.7.7 #21896
Conversation
Signed-off-by: Lan Liang <gcslyp@gmail.com>
I review this PR again. The main two bugfixes are for 0.7.6 and pulsar uses 0.7.5, so this PR can wait a little longer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added review comments about mixing grpc and vertx library versions.
@@ -436,6 +436,7 @@ The Apache Software License, Version 2.0 | |||
- io.grpc-grpc-rls-1.55.3.jar | |||
- io.grpc-grpc-servlet-1.55.3.jar | |||
- io.grpc-grpc-servlet-jakarta-1.55.3.jar | |||
- io.grpc-grpc-util-1.60.0.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixing grpc library versions doesn't look good. grpc version is currently coupled to protobuf version and also to bookkeeper version so we cannot safely upgrade protobuf. (see thread https://lists.apache.org/thread/s9g6w31vtwzgqf162hhlcr2nx3y68gv5)
@@ -478,6 +480,7 @@ The Apache Software License, Version 2.0 | |||
- io.vertx-vertx-web-4.3.8.jar | |||
- io.vertx-vertx-web-common-4.3.8.jar | |||
- io.vertx-vertx-grpc-4.3.5.jar | |||
- io.vertx-vertx-grpc-4.5.1.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixing vertx libraries versions doesn't look good.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
Bump jetcd to 0.7.7, it's major fix two bug and Upgrade of related dependencies.
Bug fixes:
Full details: etcd-io/jetcd@jetcd-0.7.5...jetcd-0.7.7
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: pulsar-sigs#6