[fix][meta] Bump jetcd to 0.7.7 #21896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lan Liang <gcslyp@gmail.com>
|
I review this PR again. The main two bugfixes are for 0.7.6 and pulsar uses 0.7.5, so this PR can wait a little longer. |
lhotari
requested changes
Jan 15, 2024
| @@ -436,6 +436,7 @@ The Apache Software License, Version 2.0 | |||
| - io.grpc-grpc-rls-1.55.3.jar | |||
| - io.grpc-grpc-servlet-1.55.3.jar | |||
| - io.grpc-grpc-servlet-jakarta-1.55.3.jar | |||
| - io.grpc-grpc-util-1.60.0.jar | |||
There was a problem hiding this comment.
Mixing grpc library versions doesn't look good. grpc version is currently coupled to protobuf version and also to bookkeeper version so we cannot safely upgrade protobuf. (see thread https://lists.apache.org/thread/s9g6w31vtwzgqf162hhlcr2nx3y68gv5)
| @@ -478,6 +480,7 @@ The Apache Software License, Version 2.0 | |||
| - io.vertx-vertx-web-4.3.8.jar | |||
| - io.vertx-vertx-web-common-4.3.8.jar | |||
| - io.vertx-vertx-grpc-4.3.5.jar | |||
| - io.vertx-vertx-grpc-4.5.1.jar | |||
There was a problem hiding this comment.
Mixing vertx libraries versions doesn't look good.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
Bump jetcd to 0.7.7, it's major fix two bug and Upgrade of related dependencies.
Bug fixes:
Full details: etcd-io/jetcd@jetcd-0.7.5...jetcd-0.7.7
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: pulsar-sigs#6